Textboxes with emptytext shouldn't enable undo for display and deletion of empty text

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Toolkit
XUL Widgets
--
minor
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: graememcc, Assigned: graememcc)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
verified1.9.1
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Spinning this off from bug 471319...

That bug found a problem in the editor code with undo/redo. However, part of the problem is that undo shouldn't be enabled in the first place when there hasn't been a user edit.
(Assignee)

Comment 1

8 years ago
Created attachment 355036 [details] [diff] [review]
Patch

When clearing empty text, try and clean up after ourselves.
Attachment #355036 - Flags: review?(gavin.sharp)
Whiteboard: [has patch][needs review gavin]
(Assignee)

Updated

8 years ago
Duplicate of this bug: 476269
Gavin, do you have time to review this patch?
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
Flags: wanted1.9.1?
Flags: in-testsuite?
(Assignee)

Updated

8 years ago
Attachment #355036 - Flags: review?(gavin.sharp) → review?(enndeakin)
(Assignee)

Comment 4

8 years ago
Comment on attachment 355036 [details] [diff] [review]
Patch

Neil, are you able to review this change at all?
Whiteboard: [has patch][needs review gavin] → [has patch][needs review enndeakin]

Updated

8 years ago
Attachment #355036 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 5

8 years ago
Created attachment 361632 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: [has patch][needs review enndeakin]
Comment on attachment 361632 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]


http://hg.mozilla.org/mozilla-central/rev/787fde278f78
Attachment #361632 - Attachment description: hg export for checkin → hg export for checkin [Checkin: Comment 6]
Blocks: 471319
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Updated

8 years ago
Attachment #361632 - Flags: approval1.9.1?
Verified fixed with builds on OS X and Windows:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090216 Minefield/3.2a1pre ID:20090216020430
Status: RESOLVED → VERIFIED
Comment on attachment 361632 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]

a191=beltzner
Attachment #361632 - Flags: approval1.9.1? → approval1.9.1+

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/606eb5827cd4
Keywords: checkin-needed → fixed1.9.1
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090404 Shiretoko/3.5b4pre ID:20090404035045 and on Windows.

What about the location bar? It looks somewhat inconsistent in its behavior. Opening a new tab, clicking away, and opening its context menu still shows the undo entry enabled. I can go back several steps and at some point urls are shown which were entered in other tabs. Do we share the undo stack between tabs? I think that's a bug. I wanted to ask before I file a new bug on that issue.
Flags: wanted1.9.1?
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.