Closed
Bug 471871
Opened 17 years ago
Closed 16 years ago
Bugzilla::Version has duplicated code compared to Bugzilla::Object
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: LpSolit, Assigned: LpSolit)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
12.72 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Bugzilla::Version is supposed to be based on Bugzilla::Object, but it only partially uses methods defined there, probably because Bugzilla::Object implementation wasn't complete yet. It's high time to fix that.
|
Assignee | |
Updated•16 years ago
|
Target Milestone: Bugzilla 4.0 → Bugzilla 3.6
|
|
Assignee | |
Comment 2•16 years ago
|
||
Pretty straightforward.
Attachment #371853 -
Flags: review?(mkanat)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Oops, I forgot to fix all places.
Attachment #371853 -
Attachment is obsolete: true
Attachment #371854 -
Flags: review?(mkanat)
Attachment #371853 -
Flags: review?(mkanat)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 371854 [details] [diff] [review]
patch, v1.1
Looks great. Changes message should say "Version renamed to" instead of "Version renamed as".
Attachment #371854 -
Flags: review?(mkanat) → review+
|
|
||
Updated•16 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Checking in editversions.cgi;
/cvsroot/mozilla/webtools/bugzilla/editversions.cgi,v <-- editversions.cgi
new revision: 1.59; previous revision: 1.58
done
Checking in Bugzilla/Install.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install.pm,v <-- Install.pm
new revision: 1.20; previous revision: 1.19
done
Checking in Bugzilla/Product.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Product.pm,v <-- Product.pm
new revision: 1.36; previous revision: 1.35
done
Checking in Bugzilla/Version.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Version.pm,v <-- Version.pm
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl
new revision: 1.84; previous revision: 1.83
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl
new revision: 1.279; previous revision: 1.278
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•