Closed Bug 471886 Opened 11 years ago Closed 11 years ago

Make places autocomplete tests even more robust against default prefs

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

In bug 468341, I made a number of places autocomplete tests more robust against defaults set for the the browser.urlbar.search.sources pref, we should do the same for browser.urlbar.default.behavior (introduced in bug 463459) before SeaMonkey switches over to setting that instead of search.sources to history-only matching by default (which will probably happen as a part of bug 468326).
This patch makes us set default.behavior as well on those tests, so we pass even if that pref is set to something else by default in the app we're running in.
Attachment #355136 - Flags: review?(edilee)
Comment on attachment 355136 [details] [diff] [review]
set default.behavior as well

Shouldn't be needed once we get bug 472603 in, but EIBTI.

Good thing I created that head_autocomplete to standardize all those tests :) hehe
Attachment #355136 - Flags: review?(edilee) → review+
Pushed as http://hg.mozilla.org/mozilla-central/rev/ebc083cea40b and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/18f1b93314ed - BTW, bug 472603 will probably not so away with needing this, as IIRC an xpcshell in a SeaMonkey build still gets the different default pref SeaMonkey has (searching only in history).
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
this was missing fixed1.9.1 keyword
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.