Closed Bug 471903 Opened 12 years ago Closed 12 years ago

pref urlbar.autocomplete.enabled is no longer implemented

Categories

(Toolkit :: Places, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dietrich, Assigned: Mardak)

References

Details

(Keywords: fixed1.9.1, regression)

Attachments

(1 file)

it's set during IE migration:

http://mxr.mozilla.org/mozilla-central/search?string=urlbar.autocomplete.enabled

and defined, but not used in Places:

http://mxr.mozilla.org/mozilla-central/ident?i=PREF_AUTOCOMPLETE_ENABLED


if it's a valid IE setting for toggling autocomplete and is turned off, we should set browser.urlbar.search.sources = 0.
Seamonkey is expecting autocomplete.enabled, and search.sources should probably go away per bug 472943.

We can fix both by changing search.sources=0 into autocomplete.enabled and then fix firefox ui to use default.behavior instead of search.sources for the dropdown.

I'll whip something up for trunk and probably request blocking 191 or something.
Blocks: 472943
Keywords: regression
Summary: pref urlbar.autocomplete.enabled is unused → pref urlbar.autocomplete.enabled is no longer implemented
Target Milestone: --- → mozilla1.9.2a1
Attached patch v1Splinter Review
Hook up the dropdown to two prefs and always update .enabled. Remove search.sources and switch turning off ability to check .enabled.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #357376 - Flags: review?(dietrich)
setting p1, as mardak says it breaks AC for seamonkey
Severity: normal → critical
Priority: -- → P1
Attachment #357376 - Flags: review?(dietrich) → review+
Comment on attachment 357376 [details] [diff] [review]
v1

r=me. the pref is less easy to understand, but since we have UI for the common cases, i'm not so worried about it. the lack of confusion over two prefs is definite win.
Moved pref to "toolkit.js" (all.js) from firefox.js.

http://hg.mozilla.org/mozilla-central/rev/68391d886801
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
b191? as seamonkey has broken functionality with this regression.
Flags: blocking1.9.1?
Attachment #357376 - Flags: approval1.9.1?
Comment on attachment 357376 [details] [diff] [review]
v1

a191? to fix seamonkey. Has tests and cleans up prefs.
Flags: blocking1.9.1? → blocking1.9.1+
Attachment #357376 - Flags: approval1.9.1?
dev-doc-needed: Just incase the pref was lost in the docs somewhere along the way because it wasn't implemented earlier.
Keywords: dev-doc-needed
We don't really have documentation for these sorts of preferences at all right now.  There's a separate bug already for adding documentation to cover prefs, so I'm removing teh doc needed tag here.
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.