Closed Bug 472021 Opened 16 years ago Closed 16 years ago

mail.unknown is not a sandwich

Categories

(MailNews Core :: MIME, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch Remove itSplinter Review
For the last nine or ten years, every time mimedrft.cpp wanted to build up some compose fields to open a compose window, it would GetMailXlateionPreference() (oh, my eyes! the English language does *not* do that) and GetMailSigningPreference(), somehow making sense of the fact that the values for both were stored in the same preference, "mail.unknown". Reasonable as that might be, CreateCompositionFields() just didn't care: it might have them in its arguments list, but it wasn't about to do anything with them.

Richie's gone, "the new world" is now "the old world," time to give up on porting whatever 4.x pref that was.
Attachment #355268 - Flags: superreview?(bienvenu)
Attachment #355268 - Flags: review?(bienvenu)
Comment on attachment 355268 [details] [diff] [review]
Remove it

heh, agreed, thx, Phil.
Attachment #355268 - Flags: superreview?(bienvenu)
Attachment #355268 - Flags: superreview+
Attachment #355268 - Flags: review?(bienvenu)
Attachment #355268 - Flags: review+
http://hg.mozilla.org/comm-central/rev/6676db102f4b
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: