472218 - "ASSERTION: bad value" with float, large padding

Status: VERIFIED FIXED

(Core :: Layout: Floats, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: bad value: 'Not Reached', file /Users/jruderman/central/layout/generic/nsFloatManager.cpp, line 149

nsFloatManager.cpp was added yesterday, in bug 191448.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I guess I should just make these NS_WARN_IF_FALSE.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

These should be warnings rather than assertions since large coordinates are something we have to deal with.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed: http://hg.mozilla.org/mozilla-central/rev/2a4999efa837

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed on 1.9.1 along with the patch that caused the regression:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3d50c726626b

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED (with attached test case) using debug builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090608 Shiretoko/3.5pre ID:20090608122057

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090608 Minefield/3.6a1pre ID:20090608122028