Last Comment Bug 472252 - Textarea drops below floated block
: Textarea drops below floated block
: fixed1.9.1, regression, testcase
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: P1 normal (vote)
: mozilla1.9.1b3
Assigned To: David Baron :dbaron: ⌚️UTC-10
: Jet Villegas (:jet)
Depends on:
Blocks: 191448
  Show dependency treegraph
Reported: 2009-01-05 19:07 PST by philippe (part-time)
Modified: 2010-12-17 06:29 PST (History)
8 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

minimised testcase (478 bytes, text/html)
2009-01-05 19:07 PST, philippe (part-time)
no flags Details
patch (9.15 KB, patch)
2009-01-06 14:50 PST, David Baron :dbaron: ⌚️UTC-10
roc: review+
roc: superreview+
Details | Diff | Splinter Review

Description philippe (part-time) 2009-01-05 19:07:56 PST
Created attachment 355507 [details]
minimised testcase

The 'reply' textarea in the mozillazine forums drops below the floated block containing the 'smilies' samples.

The textarea on those pages has a width:100% declared, which makes it 2px wider than the parent block (due to the border of the textarea).

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090104 Minefield/3.2a1pre (tinderbox hourly build, 17:42)

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090104 Minefield/3.2a1pre

--> 191448
Comment 1 David Baron :dbaron: ⌚️UTC-10 2009-01-06 13:50:17 PST
I wrote a bunch of tests (layout/reftests/floats/other-float-outside-*) to test issues related to this type of situation, but it seems they weren't sufficient.

I suppose they all test it based on the mBandHasFloats checks in nsBlockReflowState::CanPlaceFloat, and this case is related to the mBandHasFloats check in nsBlockReflowState::ClearFloats.

I'll investigate further...
Comment 2 David Baron :dbaron: ⌚️UTC-10 2009-01-06 14:06:56 PST
It turns out those tests weren't doing what I thought they were because I had a ":" where I should have had a ";".  (That actually fits; the result surprised me, but I just implemented it anyway.)
Comment 3 David Baron :dbaron: ⌚️UTC-10 2009-01-06 14:50:03 PST
Created attachment 355666 [details] [diff] [review]

Fixes my bad tests, adds attachment 355507 [details] to reftest, and fixes nsFloatManager to be compatible with nsSpaceManager (although not necessarily correct, but I think compatible with other browsers).

Full reftests pass.
Comment 4 David Baron :dbaron: ⌚️UTC-10 2009-01-06 15:27:46 PST
Comment 5 philippe (part-time) 2009-01-07 04:12:21 PST
verified with

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090107 Minefield/3.2a1pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090107 Minefield/3.2a1pre
Comment 6 David Baron :dbaron: ⌚️UTC-10 2009-02-12 20:03:18 PST
Landed on 1.9.1 along with the patch that caused the regression:

Note You need to log in before you can comment on or make changes to this bug.