472466 - No small icons in edit event/task dialog available

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- open the edit event/task dialog
- open the customize toolbar dialog
- check the 'Use Small Icons' control

RESULT:
=======

- the icon size isn't changed

EXPECTED RESULT:
================

- a toolbar with small icons

REPRODUCIBLE:
=============

- always

Comment 1

[Berend Cornelius]

For the toolbar icons in the dialog no small version is available (see calendar/base/themes/[w|p]instripe/dialogs/calendar-event-dialog-toolbar.png)

Comment 3

[Markus Adrario [:Taraman]]

Can we disable the option in the customize dialog?

Comment 4

[Stefan Sitter [:ssitter]]

A better solution would be to provide small icons. Current event dialog toolbar is just a combination of the old Thunderbird toolbars:

http://mxr.mozilla.org/comm-central/source/calendar/base/themes/pinstripe/dialogs/calendar-event-dialog-toolbar.png
http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/pinstripe/mail/compose/compose-toolbar.png
http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/pinstripe/mail/icons/mail-toolbar.png

http://mxr.mozilla.org/comm-central/source/calendar/base/themes/winstripe/dialogs/calendar-event-dialog-toolbar.png
http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/qute/mail/compose/compose-toolbar.png
http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/qute/mail/icons/mail-toolbar.png

We could copy the current toolbars again (but both large and small) version and update the css rules.

Comment 5

[Markus Adrario [:Taraman]]

If the Small Icons are at hand, that is the better solution.

Taking over then.

Comment 6

[Markus Adrario [:Taraman]]

Attachment: Patch V1

Built and tested ok on Windows with winstripe theme.

Pinstripe unchecked.

Comment 7

[Markus Adrario [:Taraman]]

Attachment: Patch V1.1 - include .png files

forgot to include the images... ;-(

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 423869 [details] [diff] [review]
Patch V1.1 - include .png files


>--- a/calendar/base/themes/pinstripe/dialogs/calendar-event-dialog.css
>+++ b/calendar/base/themes/pinstripe/dialogs/calendar-event-dialog.css
> 
>+toolbar[iconsize="small"] #button-save {
>+  -moz-image-region: rect(0px 144px 24px 1620px);
>+}
>+toolbar[iconsize="small"] #button-save[disabled="true"],
>+toolbar[iconsize="small"] #button-save[disabled="true"]:hover,
>+toolbar[iconsize="small"] #button-save[disabled="true"]:hover:active {
>+  -moz-image-region: rect(48px 144px 72px 120px);
>+}

I think 1620px should be 120px, otherwise the patch looks fine to me.

r=ssitter. I don't think we need ui-review because we just add the small version of the existing icons.

Comment 9

[Markus Adrario [:Taraman]]

Attachment: Patch V1.2

>+  -moz-image-region: rect(0px 144px 24px 1620px);
>I think 1620px should be 120px, otherwise the patch looks fine to me.

Damn, I knew I would miss a typo in this. ;-)

And I found one more:
+toolbar[iconsize="small"] #button-spellcheck {
+    -moz-image-region: rect(0px 48px 216px 32px);
which should read 16 iso 216

Patch updated

Comment 10

[Markus Adrario [:Taraman]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/0a8ce305dbdc>

-> FIXED

Comment 11

[Damian Szczepanik]

verified with

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100204 Calendar/1.0b2pre

Comment 12

[Stefan Sitter [:ssitter]]

(In reply to comment #11)

How? This fix is not available in comm-1.9.1 based builds like Sunbird 1.0b2pre.