472487 - Default filename not used in non-save mode on Mac

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 374011 comment 87.  I looked at the cocoa nsFilePicker.mm, and it doesn't use the default filename provided in modes other than "save".  It should, to actually implement the nsIFilePicker API.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Somewhat like this

The only problem is that this still doesn't make the file show up when I do the Cmd-Shift-G thing to bring up a textfield to type in.  Is there a way to do that?

Comment 2

[Josh Aas]

Comment on attachment 355746 [details] [diff] [review]
Somewhat like this

>+  // set up default file name
>+  NSString* defaultFilename = [NSString stringWithCharacters:(const unichar*)inDefaultName.get() length:inDefaultName.Length()];

"stringWithCharacters:length:" documentation: "Important: Raises an exception if chars is NULL, even if length is 0."

Gotta null check that. That is also not null-checked in "nsFilePicker::PutLocalFile", please fix that instance as well.

Comment 3

[Josh Aas]

I guess that can't be null, never mind.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/5e45ba40a88a

Resolving, but if we can make my question from comment 1 work too, that would be nice.