472558 - onSecurityChange fired too often

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

Gavin says we can add a guard checking for https urls.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This should help, by avoiding work when transitioning between non-https pages. We could probably push this further and avoid more state changes when the state is the same but for a different host, but that's probably not worth optimizing.

I had to create a global progress listener to properly keep state among different tabs. I'm going to prepare a similar patch for Firefox, since we're sharing essentially the same code here and it would be nice to keep them in sync.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: merged w/tip

Comment 3

[(dormant account)]

two things 
a)
onSecurityChange is no longer fired on startup(i believe that's due to mfinkle's if (!firstTab) guard in selectedTab

b) is Browser.currentTab a typo? The only reference to that is in your patch.
perhaps you meant selectedTab?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yeah, should be selectedTab - that change was committed after I wrote the patch (bug 468880).

Comment 5

[(dormant account)]

Since you added a hook to so many methods, i suggest using _selectedTab directly to save cpu time. With that change, the performance impact of the patch on startup is negligible.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Er, the getter has a measurable impact!? It just returns _selectedTab directly...

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I think this is no longer relevant.