Closed
Bug 472609
Opened 16 years ago
Closed 15 years ago
Support Win64 (LLP64 model) for xpcom/ds
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 1 obsolete file)
|
516 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Microsoft VC++ Compiler for Windows 64bit uses LLP64 model. PtrBits in xpcom/ds is not compatible for LLP64.
|
Assignee | |
Updated•16 years ago
|
Attachment #355914 -
Flags: review?(benjamin)
|
||
Updated•16 years ago
|
Attachment #355914 -
Flags: review?(benjamin) → review-
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 355914 [details] [diff] [review] patch v1 I think JSUWord is what you want here... PtrBits should be an integer type the same size as void*, right?
|
|
Assignee | |
Comment 2•15 years ago
|
||
I think that best way is that using PRUword. If you say JSUword is best way, jstypes have to include on some headers. (bug 478190 for /mozilla/dom tree etc)
Attachment #355914 -
Attachment is obsolete: true
Attachment #361968 -
Flags: review?(benjamin)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 361968 [details] [diff] [review] patch v2 Yes, exactly, PRUword for mozilla code, JSUword for spidermonkey.
Attachment #361968 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
landed http://hg.mozilla.org/mozilla-central/rev/f939168ee9f4
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•