Closed Bug 472609 Opened 11 years ago Closed 11 years ago

Support Win64 (LLP64 model) for xpcom/ds

Categories

(Core :: XPCOM, defect)

x86_64
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch v1 (obsolete) — Splinter Review
Microsoft VC++ Compiler for Windows 64bit uses LLP64 model. 
PtrBits in xpcom/ds is not compatible for LLP64.
Attachment #355914 - Flags: review?(benjamin)
Attachment #355914 - Flags: review?(benjamin) → review-
Comment on attachment 355914 [details] [diff] [review]
patch v1

I think JSUWord is what you want here... PtrBits should be an integer type the same size as void*, right?
Attached patch patch v2Splinter Review
I think that best way is that using PRUword.

If you say JSUword is best way, jstypes have to include on some headers. (bug 478190 for /mozilla/dom tree etc)
Attachment #355914 - Attachment is obsolete: true
Attachment #361968 - Flags: review?(benjamin)
Comment on attachment 361968 [details] [diff] [review]
patch v2

Yes, exactly, PRUword for mozilla code, JSUword for spidermonkey.
Attachment #361968 - Flags: review?(benjamin) → review+
landed
http://hg.mozilla.org/mozilla-central/rev/f939168ee9f4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.