472632 - View source isn't reading from the cache

Status: RESOLVED FIXED

(Core Graveyard :: View Source, defect)

Description

[[e-mail]]

As per bug 469302 and its duplicate, we need to QI the session history before we can add an entry to it.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Curtis Bartley [:cbartley]]

Shouldn't this patch be identical to the one on 469302?

Comment 3

[Ian Neal]

Comment on attachment 355928 [details] [diff] [review]
Proposed patch

r=me with just a comment in the bug as to why it's best to leave loadFromURL where it is.

Comment 4

[[e-mail]]

Pushed changeset 865f907bb16b to comm-central, with an extra comment change to indicate why I only set loadFromURL at the end of the try block.

Comment 5

[Phil Ringnalda (:philor)]

Hmm, so if you add view-source: to the start of a URL (so you care about Back) after a post, and there's an error adding to session history, Firefox will show the source of the right page but Back will take you back to the form rather than the result of submitting it, while SeaMonkey will show the source of the form but Back will take you back to the result of submitting instead of to the form? Nice pair of tradeoffs.