View source isn't reading from the cache

RESOLVED FIXED

Status

--
major
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
As per bug 469302 and its duplicate, we need to QI the session history before we can add an entry to it.
(Assignee)

Comment 1

10 years ago
Created attachment 355928 [details] [diff] [review]
Proposed patch
Attachment #355928 - Flags: review?(iann_bugzilla)
Shouldn't this patch be identical to the one on 469302?

Comment 3

10 years ago
Comment on attachment 355928 [details] [diff] [review]
Proposed patch

r=me with just a comment in the bug as to why it's best to leave loadFromURL where it is.
Attachment #355928 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

10 years ago
Pushed changeset 865f907bb16b to comm-central, with an extra comment change to indicate why I only set loadFromURL at the end of the try block.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Hmm, so if you add view-source: to the start of a URL (so you care about Back) after a post, and there's an error adding to session history, Firefox will show the source of the right page but Back will take you back to the form rather than the result of submitting it, while SeaMonkey will show the source of the form but Back will take you back to the result of submitting instead of to the form? Nice pair of tradeoffs.

Updated

10 years ago
Assignee: nobody → neil
Target Milestone: --- → seamonkey2.0a2

Updated

8 years ago
Component: View Source → View Source
Product: SeaMonkey → Core Graveyard
Target Milestone: seamonkey2.0a2 → ---
You need to log in before you can comment on or make changes to this bug.