472635 - Do nothing if im contexts don't match

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Ginn Chen]

On a certain configuration, a customer reported Firefox 3 will hang on startup.
The configuration is:
The server side has IIIM but didn't login to desktop. (i.e. iiim daemon isn't running)
The remote side turned off IME in iiim-properties, use ssh -X to connect to server.

When I look into it, I found a weird thing.
Firefox gets "preedit_changed" signal on mIMEData->mContext, but before that, it has already called nsWindow::SetIMEEnabled(0), it did gtk_im_context_reset for mIMEData->mContext.
So in IM_preedit_changed_cb, IMEComposeText is actually working on mIMEData->mDummyContext.

I think perhaps we should add a check in IM_preedit_changed_cb and IM_commit_cb.
We should do nothing if aContext doesn't equal to IM_get_input_context(window).

And after adding this code, the hang is gone.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 355931 [details] [diff] [review]
patch

Sounds reasonable, and looks ok for me.
But I want Katakai-san's review before +'ing.

Comment 3

[Masaki Katakai]

Comment on attachment 355931 [details] [diff] [review]
patch

Looks fine for me.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 355931 [details] [diff] [review]
patch

Thank you, Katakai-san.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ginn:

Can you commit the patch? If you don't have a permission, I'll do it.

Comment 6

[Ginn Chen]

Pushed
http://hg.mozilla.org/mozilla-central/rev/9860a796f20d

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355931 [details] [diff] [review]
patch

a191=beltzner

Comment 8

[Ginn Chen]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/accb483d03bb