Closed Bug 472679 Opened 11 years ago Closed 11 years ago

Clean up obsolete ARIA that is no longer in spec

Categories

(Firefox :: Disability Access, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.5b4

People

(Reporter: davidb, Assigned: davidb)

Details

(Keywords: access, dev-doc-complete, verified1.9.1)

Attachments

(1 file)

We have aria logic that no longer part of the specification. We should either document that in the code, or remove it.

This bug was created as some work towards this has started on bug 452388. Discussion on obsolete ARIA should happen here.
Update: I'll remove aria-datatype logic here.
Status: NEW → ASSIGNED
Surkov, why does nsXFormsAccessible::GetAttributesInternal set a datatype property?
(In reply to comment #2)
> Surkov, why does nsXFormsAccessible::GetAttributesInternal set a datatype
> property?

It was introduced in bug 367256. Since ARIA droped datatype usage then xforms is unique thing that exposes datatype to AT. If we don't need this and nobody uses it then I think we can drop the support of datatype at all.
Aaron can you give this a quick look, and also, can you comment on why datatype was dropped? Surkov wants to know and I can't remember the details.
Attachment #356560 - Flags: review?(aaronleventhal)
Attachment #356560 - Flags: review?(surkov.alexander)
Attachment #356560 - Flags: review?(marco.zehe)
Attachment #356560 - Flags: review?(marco.zehe) → review+
Comment on attachment 356560 [details] [diff] [review]
removed aria- channel,container-channel,datatype.

Trivial patch.

Please update any docs on wiki.mo or dev.mo or codetalks, etc.
Attachment #356560 - Flags: review?(aaronleventhal) → review+
Attachment #356560 - Flags: review?(surkov.alexander)
Regarding datatype, I think it may happen in ARIA 2.0. We couldn't agree on a good way to do it. It required namespaces, which wasn't good for HTML. At some point we might look at how Web Forms 2 does data types.

It would be nice to have for alternative input. Gone, but not forgotten.
Right, great for word prediction. Thank Aaron, we'll add it back if/when needed.
Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/98b0d2b220c7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> Please update any docs on wiki.mo or dev.mo or codetalks, etc.

Updated codetalks for now.
David, when you will update devmo then please don't remove docs for datatype attribute completely, just mark it doesn't exposed in firefox 3.2 any more.
(In reply to comment #10)
> David, when you will update devmo then please don't remove docs for datatype
> attribute completely, just mark it doesn't exposed in firefox 3.2 any more.

Done.
Comment on attachment 356560 [details] [diff] [review]
removed aria- channel,container-channel,datatype.

ARIA 1.0 compliance.
Attachment #356560 - Flags: approval1.9.1?
Attachment #356560 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 356560 [details] [diff] [review]
removed aria- channel,container-channel,datatype.

a191=beltzner
Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/68be6560e3f0
Keywords: fixed1.9.1
Target Milestone: --- → Firefox 3.5b4
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)
You need to log in before you can comment on or make changes to this bug.