472679 - Clean up obsolete ARIA that is no longer in spec

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

We have aria logic that no longer part of the specification. We should either document that in the code, or remove it.

This bug was created as some work towards this has started on bug 452388. Discussion on obsolete ARIA should happen here.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Update: I'll remove aria-datatype logic here.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Surkov, why does nsXFormsAccessible::GetAttributesInternal set a datatype property?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> Surkov, why does nsXFormsAccessible::GetAttributesInternal set a datatype
> property?

It was introduced in bug 367256. Since ARIA droped datatype usage then xforms is unique thing that exposes datatype to AT. If we don't need this and nobody uses it then I think we can drop the support of datatype at all.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: removed aria- channel,container-channel,datatype.

Aaron can you give this a quick look, and also, can you comment on why datatype was dropped? Surkov wants to know and I can't remember the details.

Comment 5

[Aaron Leventhal]

Comment on attachment 356560 [details] [diff] [review]
removed aria- channel,container-channel,datatype.

Trivial patch.

Please update any docs on wiki.mo or dev.mo or codetalks, etc.

Comment 6

[Aaron Leventhal]

Regarding datatype, I think it may happen in ARIA 2.0. We couldn't agree on a good way to do it. It required namespaces, which wasn't good for HTML. At some point we might look at how Web Forms 2 does data types.

It would be nice to have for alternative input. Gone, but not forgotten.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Right, great for word prediction. Thank Aaron, we'll add it back if/when needed.

Comment 8

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/98b0d2b220c7

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #5)
> Please update any docs on wiki.mo or dev.mo or codetalks, etc.

Updated codetalks for now.

Comment 10

[alexander :surkov (:asurkov)]

David, when you will update devmo then please don't remove docs for datatype attribute completely, just mark it doesn't exposed in firefox 3.2 any more.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #10)
> David, when you will update devmo then please don't remove docs for datatype
> attribute completely, just mark it doesn't exposed in firefox 3.2 any more.

Done.

Comment 12

[Marco Zehe (:MarcoZ)]

Comment on attachment 356560 [details] [diff] [review]
removed aria- channel,container-channel,datatype.

ARIA 1.0 compliance.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356560 [details] [diff] [review]
removed aria- channel,container-channel,datatype.

a191=beltzner

Comment 14

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/68be6560e3f0

Comment 15

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)