472734 - The top left corner of submenus shouldn't be rounded

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix

Comment 1

[Markus Stange [:mstange]]

Attachment: screenshot with patch

Comment 2

[Ashley Bischoff (blog at handcoding.com)]

(In reply to comment #1)
> Created an attachment (id=356040) [details]
> screenshot with patch

I'm not a developer, so I don't mean to imply deficiencies in your code, but does this also account for submenus that pop-out from the left side of a menu? 

For instance, if you move your browser window near to the right edge of your screen and then right-click nearby the right edge of the viewport, I believe the context menu will still appear normally, but any submenus off the context menu will appear to the left of the context menu, right?

Comment 3

[Markus Stange [:mstange]]

Attachment: alternative fix: keep round corners for submenus that pop up to the left

(In reply to comment #2)
> does this also account for submenus that pop-out from the left side of a menu?

No, because I didn't think it was worth the effort.

This alternative patch does account for them by keeping all corners rounded.
I tried to make the upper right corner square for them instead, but it looks like Apple doesn't provide a way of doing that.

Roc / josh, which approach do you prefer?

Comment 4

[Markus Stange [:mstange]]

Attachment: screenshot of alternative fix

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

This one seems fine

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 356038 [details] [diff] [review]
fix

ok

Comment 7

[Josh Aas]

Comment on attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

>+PRBool
>+nsNativeTheme::IsSubmenu(nsIFrame* aFrame, PRBool* aLeftOfParent)
>+{
>+  if (!aFrame)
>+    return PR_FALSE;

Should probably also check that aLeftOfParent is non-null as well.

Comment 8

[Markus Stange [:mstange]]

Attachment: null check added

Comment 9

[Markus Stange [:mstange]]

pushed: http://hg.mozilla.org/mozilla-central/rev/119de4e0e612

Comment 10

[Tony Chung [:tchung]]

Attachment: submenu on right on context - broken screenshot

image still has square corner if the submenu is to the right of the context menu popup

Comment 11

[Tony Chung [:tchung]]

Attachment: submenu on left on context - Fixed screenshot

Corner image to the left of the submenu is rounded and fixed.

Comment 12

[Tony Chung [:tchung]]

This was tested on: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre

Comment 13

[Tony Chung [:tchung]]

huh.  looks like this can't be fixed for left context menus (apple restriction)  That said, its fixed on trunk: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356561 [details] [diff] [review]
null check added

a191=beltzner

Comment 15

[Markus Stange [:mstange]]

pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/527e455e8277