The top left corner of submenus shouldn't be rounded

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Core
Widget: Cocoa
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

({fixed1.9.1, polish})

Trunk
mozilla1.9.2a1
All
Mac OS X
fixed1.9.1, polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 356038 [details] [diff] [review]
fix
Attachment #356038 - Flags: superreview?(roc)
Attachment #356038 - Flags: review?(joshmoz)
(Assignee)

Comment 1

9 years ago
Created attachment 356040 [details]
screenshot with patch
(In reply to comment #1)
> Created an attachment (id=356040) [details]
> screenshot with patch

I'm not a developer, so I don't mean to imply deficiencies in your code, but does this also account for submenus that pop-out from the left side of a menu? 

For instance, if you move your browser window near to the right edge of your screen and then right-click nearby the right edge of the viewport, I believe the context menu will still appear normally, but any submenus off the context menu will appear to the left of the context menu, right?
(Assignee)

Comment 3

9 years ago
Created attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

(In reply to comment #2)
> does this also account for submenus that pop-out from the left side of a menu?

No, because I didn't think it was worth the effort.

This alternative patch does account for them by keeping all corners rounded.
I tried to make the upper right corner square for them instead, but it looks like Apple doesn't provide a way of doing that.

Roc / josh, which approach do you prefer?
(Assignee)

Comment 4

9 years ago
Created attachment 356066 [details]
screenshot of alternative fix
Attachment #356065 - Flags: superreview+
Comment on attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

This one seems fine
(Assignee)

Updated

9 years ago
Attachment #356038 - Attachment is obsolete: true
Attachment #356038 - Flags: superreview?(roc)
Attachment #356038 - Flags: review?(joshmoz)
(Assignee)

Comment 6

9 years ago
Comment on attachment 356038 [details] [diff] [review]
fix

ok
(Assignee)

Updated

9 years ago
Attachment #356065 - Flags: review?(joshmoz)

Comment 7

9 years ago
Comment on attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

>+PRBool
>+nsNativeTheme::IsSubmenu(nsIFrame* aFrame, PRBool* aLeftOfParent)
>+{
>+  if (!aFrame)
>+    return PR_FALSE;

Should probably also check that aLeftOfParent is non-null as well.
Attachment #356065 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 8

9 years ago
Created attachment 356561 [details] [diff] [review]
null check added
Attachment #356065 - Attachment is obsolete: true
(Assignee)

Comment 9

9 years ago
pushed: http://hg.mozilla.org/mozilla-central/rev/119de4e0e612
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Updated

9 years ago
Attachment #356561 - Flags: approval1.9.1?
Created attachment 359553 [details]
submenu on right on context - broken screenshot

image still has square corner if the submenu is to the right of the context menu popup
Created attachment 359554 [details]
submenu on left on context - Fixed screenshot

Corner image to the left of the submenu is rounded and fixed.
This was tested on: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
huh.  looks like this can't be fixed for left context menus (apple restriction)  That said, its fixed on trunk: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
Comment on attachment 356561 [details] [diff] [review]
null check added

a191=beltzner
Attachment #356561 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 15

9 years ago
pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/527e455e8277
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.