The top left corner of submenus shouldn't be rounded

VERIFIED FIXED in mozilla1.9.2a1

Status

()

defect
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

({fixed1.9.1, polish})

Trunk
mozilla1.9.2a1
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 2 obsolete attachments)

Posted patch fix (obsolete) — Splinter Review
No description provided.
Attachment #356038 - Flags: superreview?(roc)
Attachment #356038 - Flags: review?(joshmoz)
(In reply to comment #1)
> Created an attachment (id=356040) [details]
> screenshot with patch

I'm not a developer, so I don't mean to imply deficiencies in your code, but does this also account for submenus that pop-out from the left side of a menu? 

For instance, if you move your browser window near to the right edge of your screen and then right-click nearby the right edge of the viewport, I believe the context menu will still appear normally, but any submenus off the context menu will appear to the left of the context menu, right?
(In reply to comment #2)
> does this also account for submenus that pop-out from the left side of a menu?

No, because I didn't think it was worth the effort.

This alternative patch does account for them by keeping all corners rounded.
I tried to make the upper right corner square for them instead, but it looks like Apple doesn't provide a way of doing that.

Roc / josh, which approach do you prefer?
Comment on attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

This one seems fine
Attachment #356038 - Attachment is obsolete: true
Attachment #356038 - Flags: superreview?(roc)
Attachment #356038 - Flags: review?(joshmoz)
Attachment #356065 - Flags: review?(joshmoz)
Comment on attachment 356065 [details] [diff] [review]
alternative fix: keep round corners for submenus that pop up to the left

>+PRBool
>+nsNativeTheme::IsSubmenu(nsIFrame* aFrame, PRBool* aLeftOfParent)
>+{
>+  if (!aFrame)
>+    return PR_FALSE;

Should probably also check that aLeftOfParent is non-null as well.
Attachment #356065 - Flags: review?(joshmoz) → review+
Attachment #356065 - Attachment is obsolete: true
pushed: http://hg.mozilla.org/mozilla-central/rev/119de4e0e612
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #356561 - Flags: approval1.9.1?
image still has square corner if the submenu is to the right of the context menu popup
Corner image to the left of the submenu is rounded and fixed.
This was tested on: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
huh.  looks like this can't be fixed for left context menus (apple restriction)  That said, its fixed on trunk: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090129 Minefield/3.2a1pre
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Comment on attachment 356561 [details] [diff] [review]
null check added

a191=beltzner
Attachment #356561 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.