472801 - Enabling updater no longer requires iconv

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: Remove check for iconv from configure.in

Now that we support unicode in the updater.ini we no longer require iconv to compile the updater on win32 (Bug 399153).

We could also remove it from mozilla-1.9.1 if you like.

Comment 1

[Axel Hecht [:Pike]]

Doesn't this depend on the unicode installer, too?

Comment 2

[Robert Strong (they/them - no direct email)]

That is a separate check
http://mxr.mozilla.org/mozilla-central/source/configure.in#5774

Comment 3

[Robert Strong (they/them - no direct email)]

Hey Frank, just a heads up... not sure how you handle configure.in changes on comm-central.

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/4fc89aa2ffec

Comment 5

[Justin Wood (:Callek)]

(In reply to comment #3)
> Hey Frank, just a heads up... not sure how you handle configure.in changes on
> comm-central.

For reference in future; myself, KaiRo, or sgauthiere might be a good CC-candidate; we also have http://dev.seamonkey.at/?d=x&i=mozilla&m=c for tracking sake.

If you ever want to patch c-c at the same time as one of these bugs, you can also r? me.

In this bugs case, being fixed by Bug 543230. Thanks for caring about us anyway!