Remove SeaMonkey workaround for test_bug465448.xul

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Core
Layout
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

({fixed1.9.1})

1.9.1 Branch
mozilla1.9.2a1
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The checkin for bug 469203 on 1.9.1 made the tests pass that we marked todo() for SeaMonkey in bug 469331, so we can revert that ugly workaround and ok() those tests everywhere.
That's not what the tinderboxes are reporting.
Maybe you made the same mistake I initially made: what you see is bug 465448 comment 19 ;->
(Assignee)

Comment 2

9 years ago
Oops, right. Thanks for spotting this (I wouldn't have thought that anyone would copy that ugly workaround elsewhere).
Assignee: kairo → nobody
Depends on: 465448
No longer depends on: 469203, 469331
Summary: Remove SeaMonkey workaround for test_bug458898.html → Remove SeaMonkey workaround for test_bug465448.xul
roc, did you do a "blind" copy&paste of that workaround,
or did you actually (as in having tested it) expect this test to fail ?

In other words, it's trivial to remove the workaround, but is it "safe" ?
Just remove it
(Assignee)

Comment 5

9 years ago
Created attachment 356232 [details] [diff] [review]
remove SeaMonkey exceptions

remove SeaMonkey exceptions and mark the tests as ok() for all cases
Assignee: nobody → kairo
Attachment #356232 - Flags: review?(roc)
roc,

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090109 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/0ff733711384)

I tried to revert the nsXULWindow.cpp part of bug 465448,
and the new test still succeeds with my local.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081230 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/6201c0669e15
 +http://hg.mozilla.org/comm-central/rev/2854a16a867f)

I also tried this new test with my (older) SM+trunk build,
and the test reports '600 x 600';
which might explain why current SeaMonkey builds succeed...


Is that bug supposed to fix some other cases/platforms, or is there something unexpected actually going on (with the fix or the test) ?
(In reply to comment #6)
> [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090109
> Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
> (http://hg.mozilla.org/mozilla-central/rev/0ff733711384)
> 
> I tried to revert the nsXULWindow.cpp part of bug 465448,
> and the new test still succeeds with my local.

This reverted build reports '117 x 216', as bug 458898 test does.
Attachment #356232 - Flags: review?(roc) → review+
(Assignee)

Comment 8

9 years ago
Pushed as http://hg.mozilla.org/mozilla-central/rev/264eca4c6c5b and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/45a7d92da7c7
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.2a1
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090117 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/a3abe1807f71 + bug 446300 patch
 +http://hg.mozilla.org/comm-central/rev/da4ab57196d6 + bug 446300 patch)

V.Fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.