Closed
Bug 472813
Opened 15 years ago
Closed 15 years ago
Remove SeaMonkey workaround for test_bug465448.xul
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: kairo, Assigned: kairo)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
1.34 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The checkin for bug 469203 on 1.9.1 made the tests pass that we marked todo() for SeaMonkey in bug 469331, so we can revert that ugly workaround and ok() those tests everywhere.
Comment 1•15 years ago
|
||
That's not what the tinderboxes are reporting. Maybe you made the same mistake I initially made: what you see is bug 465448 comment 19 ;->
Assignee | ||
Comment 2•15 years ago
|
||
Oops, right. Thanks for spotting this (I wouldn't have thought that anyone would copy that ugly workaround elsewhere).
Comment 3•15 years ago
|
||
roc, did you do a "blind" copy&paste of that workaround, or did you actually (as in having tested it) expect this test to fail ? In other words, it's trivial to remove the workaround, but is it "safe" ?
Just remove it
Assignee | ||
Comment 5•15 years ago
|
||
remove SeaMonkey exceptions and mark the tests as ok() for all cases
Assignee: nobody → kairo
Attachment #356232 -
Flags: review?(roc)
Comment 6•15 years ago
|
||
roc, [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090109 Minefield/3.2a1pre] (home, optim default) (W2Ksp4) (http://hg.mozilla.org/mozilla-central/rev/0ff733711384) I tried to revert the nsXULWindow.cpp part of bug 465448, and the new test still succeeds with my local. [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081230 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4) (http://hg.mozilla.org/mozilla-central/rev/6201c0669e15 +http://hg.mozilla.org/comm-central/rev/2854a16a867f) I also tried this new test with my (older) SM+trunk build, and the test reports '600 x 600'; which might explain why current SeaMonkey builds succeed... Is that bug supposed to fix some other cases/platforms, or is there something unexpected actually going on (with the fix or the test) ?
Comment 7•15 years ago
|
||
(In reply to comment #6) > [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090109 > Minefield/3.2a1pre] (home, optim default) (W2Ksp4) > (http://hg.mozilla.org/mozilla-central/rev/0ff733711384) > > I tried to revert the nsXULWindow.cpp part of bug 465448, > and the new test still succeeds with my local. This reverted build reports '117 x 216', as bug 458898 test does.
Attachment #356232 -
Flags: review?(roc) → review+
Assignee | ||
Comment 8•15 years ago
|
||
Pushed as http://hg.mozilla.org/mozilla-central/rev/264eca4c6c5b and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/45a7d92da7c7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.2a1
Comment 9•15 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090117 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4) (http://hg.mozilla.org/mozilla-central/rev/a3abe1807f71 + bug 446300 patch +http://hg.mozilla.org/comm-central/rev/da4ab57196d6 + bug 446300 patch) V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•