47282 - Shift+Tab in <textarea> doesn't do anything

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Blake Ross]

Build ID: 2000080108

Shift+tab is broken in <textarea>'s.  Instead of moving focus to the 
widget/element before the <textarea>, nothing happens.

Comment 1

[Blake Ross]

must fix for beta3.   Combined with the recent regression of bug 2083, this 
makes navigating out of <textarea>'s with the keyboard completely impossible.

Comment 2

[Tomer Brisker]

Also exists on linux. changing OS to all.

Comment 3

[saari (gone)]

Not sure if this is tabbing code or being consumed by the textarea

Comment 4

[Peter Trudelle]

nsbeta3-, ->future: minor inconvenience, no time left for bugs like this.

Comment 5

[saari (gone)]

Targeting Mozilla 1.0

Comment 6

[sairuh (rarely reading bugmail)]

nominating beta1 for accessibility reasons.

Comment 7

[Blake Ross]

Taking.

Comment 8

[Blake Ross]

Attachment: [patch] make shift+tab work

Comment 9

[Blake Ross]

If we decide to go the accessibility route in bug 2083, I think we can just 
remove HTMLEditor's tab handling completely.

simon, sr?

Comment 10

[timeless]

r=timeless

Comment 11

[saari (gone)]

Excellent, thanks for taking this! Yes, let shift-tab *and* tab go in and out of
text fields just like they do in IE. So you probably want to kill the editor
handling of tab for the non-shift case too.

I know this is a holy war issue, but IE works this way and we need to make the
browser keyboard accessable, and this is the standard way to do that for all the
other widgets. Those reasons are good enough for me.

Comment 12

[Akkana Peck]

Shouldn't this wait for the resolution of bug 66285 (the spec for what tab
should actually do)?

Comment 13

[rubydoo123]

when making these changes, please keep in mind the navigation for tables, 
currently the use of the tab key moves the selection forward from cell to cell, 
using the shift+tab moves the selection backwards from cell to cell

Comment 14

[kinmoz]

The patch breaks table navigation (backwards)in Composer and causes the caret to 
disappear when doing a shift-tab in text.

I'll attatch an updated version of blake's patch that prevents the problem, but 
I still think there are problems with choosing select-tab for passing on focus 
... for starters it will only pass focus backwards to the previous form widget, 
there is no way to pass focus forwards with this patch.

Comment 15

[kinmoz]

Attachment: Updated version of blake's patch that doesn't break Composer/MsgCompose.

Comment 16

[kinmoz]

Bah ... forgot to Cc myself.

Comment 17

[Blake Ross]

Attachment: [patch] updated to tip, allow tab/shift-tab without breaking anything

Comment 18

[Kathleen :Brade]

r=brade
Simon--please test and add your sr=

Comment 19

[Blake Ross]

Simon, sr?

Comment 20

[Simon Fraser [no longer active]]

sr=sfraser

Comment 21

[Blake Ross]

Checked in.

Comment 22

[sujay]

okay I see it working, however, the focus is going upward instead of downward.

is that by design ?

Comment 23

[Blake Ross]

Shift-tab focuses the first focusable previous widget, and tab focuses the 
first focusable next widget (so yes).

Comment 24

[sujay]

verified in 2/22 build.