473012 - Get Lightning to use nsIObserver for overlaying mailContext menus

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Ian Neal]

Once fillMailContextMenu starts using notifyObservers, Lightning should take advantage of that and use that to hook extra items into the context menu

Comment 1

[Ian Neal]

Looking through the code my initial thoughts are that the observers could be added/removed in imip-bar.js via the messagepane-loaded/unloaded events otherwise look for the same events in another file for example messenger-overlay-toolbar.js

Comment 2

[Ian Neal]

Attachment: Add observer to Lightning for new notification patch v0.1

I opted for using imip-bar.js as made sense to make use of the existing event listeners. The actual xul overlay could possibly be moved into imip-bar-overlay.xul but that might be worth leaving until a more general consolidation of overlay files.

Comment 3

[Berend Cornelius]

Comment on attachment 356409 [details] [diff] [review]
Add observer to Lightning for new notification patch v0.1

Very elegant improvement. r=berend.

Comment 4

[Berend Cornelius]

patch pushed to comm-central:

comm-central - changeset - 1626:4d2ac69754e9

-> fixed