Closed Bug 473012 Opened 13 years ago Closed 13 years ago
Get Lightning to use ns
IObserver for overlaying mail Context menus
Once fillMailContextMenu starts using notifyObservers, Lightning should take advantage of that and use that to hook extra items into the context menu
Looking through the code my initial thoughts are that the observers could be added/removed in imip-bar.js via the messagepane-loaded/unloaded events otherwise look for the same events in another file for example messenger-overlay-toolbar.js
I opted for using imip-bar.js as made sense to make use of the existing event listeners. The actual xul overlay could possibly be moved into imip-bar-overlay.xul but that might be worth leaving until a more general consolidation of overlay files.
Attachment #356409 - Flags: review?(Berend.Cornelius)
Comment on attachment 356409 [details] [diff] [review] Add observer to Lightning for new notification patch v0.1 Very elegant improvement. r=berend.
Attachment #356409 - Flags: review?(Berend.Cornelius) → review+
patch pushed to comm-central: comm-central - changeset - 1626:4d2ac69754e9 -> fixed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.