Closed
Bug 473053
Opened 16 years ago
Closed 16 years ago
Missing QI causes exclamation mark and DAV_REPORT_ERROR
Categories
(Calendar :: Provider: CalDAV, defect)
Calendar
Provider: CalDAV
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
7.12 KB,
patch
|
mschroeder
:
review+
|
Details | Diff | Splinter Review |
It seems that aLoader.request is now correctly QI'd to nsIRequest, but is missing a QI to nsIHttpChannel. This causes all our code that does aLoader.request.responseStatus to fail, since responseStatus is part of nsIHttpChannel. This patch fixes, and also fixes a missing backslash in a regex pattern.
Attachment #356405 -
Flags: review?(Berend.Cornelius)
|
Assignee | |
Comment 1•16 years ago
|
||
If anyone else is around to review this patch, please do :-)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 356405 [details] [diff] [review] Fix - v1 r=mschroeder
Attachment #356405 -
Flags: review?(Berend.Cornelius) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Thanks for taking over! Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/2d3e259d2c12> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
|
|
Assignee | |
Comment 4•16 years ago
|
||
Verified per http://groups.google.com/group/mozilla.dev.apps.calendar/browse_thread/thread/e52d36582fb107e8/1c85b2183599aca0#1c85b2183599aca0
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•