Closed
Bug 473159
Opened 16 years ago
Closed 16 years ago
GCAssert macros should abort() when asserts fire
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: edwsmith, Assigned: edwsmith)
References
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
AvmAssert was already fixed up this way, this patch fixes the MMgc equivalent macros
Attachment #356510 -
Flags: review?(treilly)
|
||
Comment 1•16 years ago
|
||
can we take this opportunity to put GCAssert and AvmAssert into the same implementation bucket?
|
Assignee | |
Comment 2•16 years ago
|
||
VMPI_assert()? sure; are there any VMPI precedents I can look at? I'm reluctant to have too much scope creep for this patch, but if it won't take a lot of inventing I'm up for it.
|
|
||
Comment 3•16 years ago
|
||
re: scope creep, yeah, maybe fix this as-is but add to the VMPI_ todo list.
|
|
Assignee | |
Comment 4•16 years ago
|
||
good idea: Bug 473188
|
||
Updated•16 years ago
|
Attachment #356510 -
Flags: review?(treilly) → review+
|
||
Updated•16 years ago
|
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
|
|
Assignee | |
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 6•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•