473175 - Making Spread Firefox Affiliate button codes (X)html valid

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[David Rolnitzky]

Need to change the button links to be W3 (X)html valid by replacing the following for each button code:

"&" with "&"

"=" with TBD.

http://www.htmlhelp.com/tools/validator/problems.html#amp

Comment 1

[Alex Buchanan [:abuchanan]]

just fyi, don't do this manually through the admin panel.  

this will be a simple code change, to surround the output with the urlencode() function.

Comment 2

[Majken Connor [:Kensie]]

do we want this for redesign?

Comment 3

[Mary]

Rolo -- How important is this?

Comment 4

[David Rolnitzky]

Not a blocker, but it should be changed since we strive for strict validation.

Comment 5

[Alex Buchanan [:abuchanan]]

sorry for the spam, but I need to unassign myself from these so they're open to other people to work on them

Comment 6

[Alex Buchanan [:abuchanan]]

r26426 makes this valid,

stage:
<a href='http://www.mozilla.com?from=sfx&amp;uid=232595&amp;t=2'><img src='http://sfx-images.mozilla.org/affiliates/products/firefox/upgrade_1_5_120x240b.jpg' alt='Spread Firefox Affiliate Button' border=0 /></img>

production:
<a href="http://www.mozilla.com/?from=sfx&uid=0&t=305"><img border="0" alt="Spread Firefox Affiliate Button" src="http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/110x32_best-yet.png" /></a>

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; my output:

<a href='http://www.mozilla.com?from=sfx&amp;uid=242470&amp;t=2'><img src='http://sfx-images.mozilla.org/affiliates/products/firefox/upgrade_1_5_120x240b.jpg' alt='Spread Firefox Affiliate Button' border=0 /></img>