Making Spread Firefox Affiliate button codes (X)html valid

VERIFIED FIXED in 3.0.1

Status

Websites Graveyard
spreadfirefox.com
VERIFIED FIXED
10 years ago
7 years ago

People

(Reporter: David Rolnitzky, Unassigned)

Tracking

unspecified
3.0.1
x86
Mac OS X

Details

(Whiteboard: affiliates, URL)

(Reporter)

Description

10 years ago
Need to change the button links to be W3 (X)html valid by replacing the following for each button code:

"&" with "&"

"=" with TBD.

http://www.htmlhelp.com/tools/validator/problems.html#amp
just fyi, don't do this manually through the admin panel.  

this will be a simple code change, to surround the output with the urlencode() function.
Assignee: nobody → buchanae
do we want this for redesign?
Whiteboard: affiliates

Comment 3

9 years ago
Rolo -- How important is this?
(Reporter)

Comment 4

9 years ago
Not a blocker, but it should be changed since we strive for strict validation.
Target Milestone: --- → 3.1
sorry for the spam, but I need to unassign myself from these so they're open to other people to work on them
Assignee: buchanae → nobody
Target Milestone: 3.1 → 3.0.1
r26426 makes this valid,

stage:
<a href='http://www.mozilla.com?from=sfx&amp;uid=232595&amp;t=2'><img src='http://sfx-images.mozilla.org/affiliates/products/firefox/upgrade_1_5_120x240b.jpg' alt='Spread Firefox Affiliate Button' border=0 /></img>

production:
<a href="http://www.mozilla.com/?from=sfx&uid=0&t=305"><img border="0" alt="Spread Firefox Affiliate Button" src="http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/110x32_best-yet.png" /></a>
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED; my output:

<a href='http://www.mozilla.com?from=sfx&amp;uid=242470&amp;t=2'><img src='http://sfx-images.mozilla.org/affiliates/products/firefox/upgrade_1_5_120x240b.jpg' alt='Spread Firefox Affiliate Button' border=0 /></img>
Status: RESOLVED → VERIFIED
(Assignee)

Updated

7 years ago
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.