Closed Bug 473368 Opened 11 years ago Closed 11 years ago

selecting urlbar clobbers selection clipboard

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0b1

People

(Reporter: db48x, Assigned: Gavin)

Details

Attachments

(1 file)

There are two aspects to this bug. First, anything you type is typed into the urlbar, even though the urlbar is not initially visable. Second, (on linux) selecting text makes that text the next item to be pasted, effectively causing dataloss.
I think I fixed part of this in bug 470776. The clipboard thing can be fixed by using textbox.select() rather than textbox.editor.selectAll().
(In reply to comment #1)
> I think I fixed part of this in bug 470776

...and the rest of it was probably fixed by bug 472735. I guess that just leaves the selectAll() thing.
Summary: urlbar selected on startup → selecting urlbar clobbers selection clipboard
Attached patch patchSplinter Review
.select() maps to <anonymous input>.select which maps to nsHTMLInputElement::SelectAll, which calls nsTextControlFrame::SetFormProperty(nsGkAtoms::select), which explicitly avoids nsIEditor::selectAll for precisely this reason:

http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsTextControlFrame.cpp#1946
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #357009 - Flags: review?(mark.finkle)
Attachment #357009 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/25a9966ad7f7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Fennec A3
You need to log in before you can comment on or make changes to this bug.