Closed
Bug 473392
Opened 17 years ago
Closed 17 years ago
ARM JIT fails the ecma3/Statements/eregress_74474_002/3 testcases
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
ARM
Windows Mobile 6 Professional
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brbaker, Assigned: rreitmai)
References
Details
The following acceptance testcases fail on ARM when using the JIT.
ecma3/Statements/eregress_74474_002.abc
ecma3/Statements/eregress_74474_003.abc
I have not been able to extract any additional information about the failures as this is all that is returned by the proxy tool that I use to run the test on an ARM device.
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
![]() |
Reporter | |
Comment 1•17 years ago
|
||
Marked as expected failure in testconfig.txt (1290:ef275c60b255)
Flags: in-testsuite+
![]() |
||
Comment 2•17 years ago
|
||
I supplied a patch to fix these tests just before Christmas: see http://hg.mozilla.org/users/edwsmith_adobe.com/armjit/rev/649bde8d8eda
The problem is to do with patching up branches where the final target is not known when the code is generated, and ends up being outside the range of a standard branch instruction.
![]() |
||
Comment 3•17 years ago
|
||
i integrated that patch, it's in tamarin-redux as
http://hg.mozilla.org/tamarin-redux/rev/ec80d152e803
so... perhaps it's a different problem? would you mind trying the tamain-redux tip to see if the problem is reproducable on arm linux (the build failing is on windows mobile)
![]() |
||
Comment 4•17 years ago
|
||
Oops - sorry - I hadn't noticed the platform was set to Windows!
The tests do pass with the tamarin-redux tip on my Linux setup.
![]() |
Reporter | |
Comment 5•17 years ago
|
||
These tests are now passing. Any idea why they might be working? Appears to started working with a combination of the latest nanojit restructuring for x64... The builds were also broken for a week or so unfortunately it is difficult to tell exactly when it started working... Removing the expectedfail from the testconfig.
![]() |
||
Comment 6•17 years ago
|
||
no idea, very possibly a heisenbug that ducked under the covers.
![]() |
Assignee | |
Comment 7•17 years ago
|
||
if can no longer repro, can we close this ?
![]() |
Reporter | |
Comment 8•17 years ago
|
||
These failures are intermittently causing the windows mobile acceptance run to fail. I am going to 'skip' the tests in that suite until this is resolved.
![]() |
Assignee | |
Comment 9•17 years ago
|
||
Seems like in latest runs we are *not* repro'ing this problem.
So after fixing 429673, 476639 and 477228, and ensuring that all tests are running stably, we'll re-enable these tests to run. Patch pending.
Status: NEW → ASSIGNED
![]() |
Assignee | |
Updated•17 years ago
|
Assignee: nobody → rreitmai
![]() |
Assignee | |
Comment 10•17 years ago
|
||
476639 can be removed from this dependency list since it is an enhancement
![]() |
Assignee | |
Comment 11•17 years ago
|
||
I just checked in fixes, so deps are met. Should we re-enable the tests?
![]() |
Reporter | |
Comment 12•17 years ago
|
||
Removed the skip since it has not be reproducible, pushed as 1596:74e23e3686ef
![]() |
Assignee | |
Comment 13•17 years ago
|
||
mark fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
![]() |
Reporter | |
Comment 14•16 years ago
|
||
Tests have been passing without failure for the past 7 months, "verified fixed"
Status: RESOLVED → VERIFIED
![]() |
Reporter | |
Comment 15•16 years ago
|
||
removing QRB request, bug resolved/verified
Flags: flashplayer-qrb?
You need to log in
before you can comment on or make changes to this bug.
Description
•