473453 - Make codebase compliant to stricter compilers

Status: VERIFIED INCOMPLETE

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Rishit Shah]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5
Build Identifier: 

Existing code does not compile with more sticter compilers such as RVCT and ADS.

Reproducible: Always

Comment 1

[Rishit Shah]

Attachment: Patch for making code compile with ADS/RVCT [v1]

Includes variable macro removal changes as well.  All other code changes have been reviewed.

Comment 2

[Lars T Hansen]

(In reply to comment #1)
> Created an attachment (id=356827) [details]
> Patch for making code compile with ADS/RVCT [v1]
> 
> Includes variable macro removal changes as well.  All other code changes have
> been reviewed.

IMO this should be rejected, it does too many things at once.  Patches ought to
be targeted at specific problems so that we can track the effects of each patch
individually (and others can merge them individually to work or product
branches as necessary).

Comment 3

[Edwin Smith]

+1

hg branches and mqext are both tools for managing stacks of patches, and its not very hard manually, either.  the time saved by the team is worth the extra work on the submitter.

Comment 4

[Lars T Hansen]

I believe this has been split into other bugs, reviewed, approved, applied, and committed, so this one is obsolete.