Closed Bug 473457 Opened 17 years ago Closed 16 years ago

Edit copy on "My Account" page

Categories

(Websites Graveyard :: spreadfirefox.com, defect)

Product:
Websites Graveyard
Component:
spreadfirefox.com
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mary, Assigned: paulc)

Details

Attachments

(2 files)

My Account screenshot
94.05 KB, image/tiff
Details
remove SFX CSS for inputs
123.22 KB, image/png
Details
Hi all: It isn't clear to anyone on how to change their username. The username field in My Account is missing a line of copy on how to do this. Can someone edit this? I don't think it's possible for me to do it. See attached screenshot. Current: Your preferred username; punctuation is not allowed except for periods, hyphens, and underscores. New: Your preferred username; punctuation is not allowed except for periods, hyphens, and underscores. If you would like to change your username, please enter the new one above and hit "submit" below. Thanks!
Attached image My Account screenshot —
This can only be done by altering the core user.module. paulbookers-computer:~/Development/Drupal paulbooker$ grep -r "Your preferred username" drupal5/ drupal5/httpdocs/modules/user/user.module: '#description' => t('Your preferred username; punctuation is not allowed except for periods, hyphens, and underscores.'), @Alex If you have spreadfirefox site checked out of SVN would you mind making that change , thanks
Paul, We can't modify core Drupal code. Mary, is this really necessary? The added description seems overkill to me. The process is pretty straightforward. The user is already on the "Edit" page by choice, and I don't think we need to tell them how to hit the submit button, do you? If anything, I'd recommend we add a more general description at the top, like "Below is your user account information. You can edit it. When you're done, hit the Submit button at the bottom of the page." but even that seems like stating the obvious. Paul, if we do change this, we'll need to install the module for replacing Drupal core strings. What do you think?
Thanks Alex, Yes we should definitely leave drupal core code alone. Ill see if the string overrides module will allow us to change copy http://drupal.org/project/stringoverrides
Yes, this is necessary :) People ping me and Alix constantly about changing their usernames or the email they have there. This will be a huge problem when we start changing people's usernames. It's just not clear that you can delete the email or username and enter a new one, while it is clear for passwords. A more general statement above would be great actually!
Yes, this is necessary :) People ping me and Alix constantly about changing their usernames or the email they have there. This will be a huge problem when we start changing people's usernames. It's just not clear that you can delete the email or username and enter a new one, while it is clear for passwords. A more general statement above would be great actually!
What is more clear about the password fields? I know I've got my techie blinders on, but I don't see any difference, they are both text fields. Also, before we didn't allow users to change their own user name, maybe that was what confused them? Also, maybe we can do something else to make it more clear that everything on the page is editable? I think the real problem is that the CSS style makes input fields on SFX look flat. Users expect them to look like they always do on their system. Normally something editable stands out, while something not editable is grayed out. We could change the CSS for text inputs to look more natural, that could give them an editable feel. Do you want to write some copy for a "You can edit everything here" message for the top of the page?
(In reply to comment #7) > What is more clear about the password fields? I know I've got my techie > blinders on, but I don't see any difference, they are both text fields. Re. the password fields: There are two -- enter password & confirm password with the text "To change the current user password, enter the new password in both fields." > Also, before we didn't allow users to change their own user name, maybe that > was what confused them? Yep, and now there is no indication that they are allowed to do this and how to do it. > > Also, maybe we can do something else to make it more clear that everything on > the page is editable? I think the real problem is that the CSS style makes > input fields on SFX look flat. Users expect them to look like they always do > on their system. Normally something editable stands out, while something not > editable is grayed out. We could change the CSS for text inputs to look more > natural, that could give them an editable feel. That would be pretty great! > > Do you want to write some copy for a "You can edit everything here" message for > the top of the page? Yep - gonna grab some grub and then will knock this out!
Ok... Under "Account Information" we could put the following: You may update your account information below, including your email and username. Please see our FAQ [link to FAQ] if you need additional help. We're updating the FAQ now and can get it revised before we send out this email re. username changes.
this is what the my account page looks like with the CSS removed for input fields
Is anyone working on this at the moment ?
So are we going to use stringoverrides for this one?
(In reply to comment #12) > So are we going to use stringoverrides for this one? There is no string to be overridden :( One option would be to add a hook_form_alter to /sites/all/modules/sfx/sfx.module (a misc. module for cases like this). It would be easy enough to use that to add a <p> at the top of the form. Paul, this should be pretty simple, think you could pick this one up?
Yes , ill take this Alex. I'm a little busy a the moment some work for my employer but ill get to this as soon as i can
Assignee: nobody → paul
Or Paul C. can help too If you're too busy to work on it, maybe you should leave it unassigned so that Paul C. or others know it's OK to work on it.
Yep , ill unassign myself Alex. Thanks for your help Paul C :-)
Assignee: paul → nobody
(In reply to comment #13) > (In reply to comment #12) > > So are we going to use stringoverrides for this one? > > There is no string to be overridden :( Really? I tested this locally by replacing the strings Mary mentioned, one with the other, in admin/settings/stringoverrides
Assignee: nobody → paul.craciunoiu
Hey Paul C: Is it possible to see this on stage?
Hey Mary: I can't say, I don't have admin access. If anyone here does, please grant me access.
And my user is paulc.
@ Mary | Alex If i can get clearance, ill make that change.
Done. It works on my edit: https://spreadfirefox.authstage.mozilla.com/user/228066/edit Please verify.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.0
Hey guys: Catching up here on this bug. One of the original requests was to have the following text under "account information": You may update your account information below, including your email and username. Please see our FAQ [link to FAQ] if you need additional help. Is this possible to add?
Paul C, I comment #1 is no longer valid. We're leaving the Username: field description text alone, and doing comment #23 instead String overrides can't do comment #23
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Does the FAQ actually have the desired info that would be linked to? In either case I think linking away is less desirable than having the explanatory text under the field. "You may update your account information below, including your email and username." would be good to have above, and i think the text explaining how to change the username below should cover this.
Hey there: If string override doesn't work -- PaulC were you able to do what Alex suggested?
Let's go with Lucy's suggestion: "You may update your account information below, including your email and username." at the top of the account page.
r23540 https://spreadfirefox.authstage.mozilla.com/user/232595/edit
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Verified FIXED on https://spreadfirefox.authstage.mozilla.com/user/242470/edit: "You may update your account information below, including your email and username."
Status: RESOLVED → VERIFIED
Sweet :)
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: