Closed
Bug 473511
Opened 16 years ago
Closed 16 years ago
Remove nsISVGValueObserver from nsSVGInnerSVGFrame
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: craig.topper, Assigned: craig.topper)
Details
Attachments
(1 file)
|
7.80 KB,
patch
|
jwatt
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
nsSVGInnerSVGFrame inherits from nsISVGValueObserver, but nothing ever registers it as an observer. This also removes the need for nsISupports routines in that class.
Patch also removes some unnecessary includes of nsISVGValue related files in some other frame classes.
Attachment #356906 -
Flags: review?(jwatt)
|
Assignee | |
Comment 1•16 years ago
|
||
Oops accidentally submitted a changes to remove AddObserver and RemoveObserver from nsSVGUtils. They aren't used anywhere so its valid, but I didn't mean to sneak it in like that. Let me know if you want it removed.
|
||
Comment 2•16 years ago
|
||
Comment on attachment 356906 [details] [diff] [review]
Patch
Looks good. r=jwatt
Just leave in those extra changes.
Attachment #356906 -
Flags: superreview?(roc)
Attachment #356906 -
Flags: review?(jwatt)
Attachment #356906 -
Flags: review+
Attachment #356906 -
Flags: superreview?(roc) → superreview+
Keywords: checkin-needed
Whiteboard: [needs landing]
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•