Closed Bug 473511 Opened 11 years ago Closed 11 years ago

Remove nsISVGValueObserver from nsSVGInnerSVGFrame

Categories

(Core :: SVG, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: craig.topper, Assigned: craig.topper)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
nsSVGInnerSVGFrame inherits from nsISVGValueObserver, but nothing ever registers it as an observer. This also removes the need for nsISupports routines in that class.

Patch also removes some unnecessary includes of nsISVGValue related files in some other frame classes.
Attachment #356906 - Flags: review?(jwatt)
Oops accidentally submitted a changes to remove AddObserver and RemoveObserver from nsSVGUtils. They aren't used anywhere so its valid, but I didn't mean to sneak it in like that. Let me know if you want it removed.
Comment on attachment 356906 [details] [diff] [review]
Patch

Looks good. r=jwatt

Just leave in those extra changes.
Attachment #356906 - Flags: superreview?(roc)
Attachment #356906 - Flags: review?(jwatt)
Attachment #356906 - Flags: review+
Attachment #356906 - Flags: superreview?(roc) → superreview+
Pushed http://hg.mozilla.org/mozilla-central/rev/ea2a8b91268d
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.