47353 - ModifyRequest HTTPNotify listener is called before all headers are set

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Thomas Lendacky]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (WinNT; U)
BuildID:    2000073008

The ModifyRequest HTTPNotify listener is called before all headers have been 
set.  I am working on Platform for Privacy Preferences (P3P) which has a concept 
of a "safe zone."  Whenever requesting P3P related files, certain headers should 
not be sent (cookies, agent and referer).  However, I can't remove these headers 
since they are set after the call to ModifyRequest.

Reproducible: Always
Steps to Reproduce:
1. Go to any web page

Actual Results:  When the ModifyRequest HTTPNotify listener is called not all of 
the headers that will flow on the request have been set.

Expected Results:  All of the headers that will flow on the request should be 
set before the invocation of the ModifyRequest HTTPNotify listener.

Attached is a diff with a change that I made to nsHTTPChannel.cpp to cause the 
redrive of the original headers.

Comment 1

[Thomas Lendacky]

Just re-read what I wrote.  The last paragraph on the original submission was 
left over from a previous submission.  I don't have any diffs for this problem.

Comment 2

[Gervase Markham [:gerv]]

Confirming for triage. Thomas Lendacky - I have upgraded your Bugzilla 
priviledges so you create NEW bugs by default, as you are a developer.

Gerv

Comment 3

[Gagan]

http bugs to "Networking::HTTP"

Comment 4

[Darin Fisher]

hoping to fix this for moz 1.0

Comment 5

[Darin Fisher]

this should be fixed now... reporter: please verify against a recent nightly
build.  thanks!

Comment 6

[Jimmy Lee]

Old stuff.  Catching up.  If this is still a problem, please reopen.  Marking
Verified!