473536 - Tags textbox on editBookmarkPanel is too narrow for a large font

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: screenshot

- Windows 2000
- Windows Standard (extra large)

Comment 1

[Marco Bonardo [:mak]]

i was also thinking we could probably change min-width to em

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch

Dao, do you think moving to ems could be enough?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 357371 [details] [diff] [review]
patch

Using em is good for large fonts, but it won't help locales where "Separate tags with commas" is longer.

Comment 4

[Marco Bonardo [:mak]]

well, and italian is one of those, not sure if we can make so that the autocomplete field leads the size.

Comment 5

[Marco Bonardo [:mak]]

the strange thing is that i've tried to locally backout bug 413053 and the issue is still present...
And i see the same issue in the 12-01 nightly:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090112 Minefield/3.2a1pre
This does not contain my patch... i'll look for a better regression range

Comment 6

[Dão Gottwald [:dao]]

What exactly are you looking for? The fact that the emptytext can be too long isn't a regression.

Comment 7

[Marco Bonardo [:mak]]

exactly, the textbox (and the panel) was taking the width of the empty text previously, it's not doing it anymore

Comment 8

[Dão Gottwald [:dao]]

It never did, as far as I know.

Comment 9

[Marco Bonardo [:mak]]

that's strage because in my italian version of 3.0.5 the text that is "Separare più etichette con una virgola" is not cut at all

Comment 10

[Marco Bonardo [:mak]]

mh you're right, the fact the text is not cut happens due to menulist contents being larger too.
So this is good to go, thanks.

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a3abe1807f71

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 357371 [details] [diff] [review]
patch

requesting approval, needed to fix a regression with panel re-alignment

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reporter, can you please check if this fixes the issue for you on trunk? Thanks.

Comment 14

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #13)
> Reporter, can you please check if this fixes the issue for you on trunk?

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090120 Minefield/3.2a1pre

I confirmed fix of this bug. There is no problem.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Akihiro. It would be great if you could also check the fix after it has been fixed on 1.9.1 branch. Marking verified.

Comment 16

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b489501f6929

pushed since this is a regression fix for an approved bug

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Akihiro, could you please check with Shiretoko if it is fixed for you?

Comment 18

[AKIHIRO Misaki (a.k.a Kuden)]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b4pre) Gecko/20090313 Shiretoko/3.1b4pre {Build ID: 20090313014819}
Desktop design: Windows Standard (extra large)

There is no problem. 
If this is not good, Localizer will do fix to this by using intl.css.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks! Marking verified1.9.1 based on comment 18.

Comment 20

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv