473663 - Autofill Subject on Comments with discussion topic subject they are responding to

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Mary]

Currently when you comment on a discussion topic the subject field is blank and one needs to figure out what the discussion topic was originally called.  The end result is a disjointed conversation chain where each response has a different subject.

Can we get it to autofill with "Re.: topic"?

Comment 1

[Paul Booker]

We can probably do this with some jquery.

Not sure if see any real difficulty here.

There are some configuration options for the comments module @ admin/content/comment/settings such as having a flat list display mode or disabling the comment subject field.

Let me know if you still need me to implement this change

Paul

Comment 2

[Alex Buchanan [:abuchanan]]

(In reply to comment #1)
> We can probably do this with some jquery.
> 
Paul, we normally try to solve problems like this without jQuery, because we want to support non-JS users too.

> 
> There are some configuration options for the comments module @
> admin/content/comment/settings such as having a flat list display mode or
> disabling the comment subject field.
> 

Mary, disabling the comment subject field for group posts sounds like what you're after.

Paul, please disable the comment subject field and let us know here when you do so we can check it out on stage.

Thanks!

Comment 3

[Paul Booker]

Ok, it's done.

https://spreadfirefox.authstage.mozilla.com/admin/content/comment/settings

Comment 4

[Mary]

Will play around w. this.  Thanks!

Comment 5

[Mary]

Hey there: Been checking this out.  We have "threaded expanded" list selected and I have disabled allowing commenters to create their own subject.  This results in a reply that doesn't have the same subject, but instead takes the first part of my comment as the subject.  See here:  https://spreadfirefox.authstage.mozilla.com/node/3049#comments

There doesn't seem to be an option for me the reply to automatically take the subject of the comment its replying to.

Am I missing something here?

Comment 6

[Mary]

Very odd...so when I submitted the comment there was no subject but the first sentence of my comment.  Now it appears as "re: test" on recent discussions.

Can someone else play around here?

Comment 7

[Alex Buchanan [:abuchanan]]

in r23812, I've removed the title from comments and tweaked the CSS.  That takes care of the disjointed comment title problem (saves space, and looks better), so I think that fixes this bug.  If not, sorry, please reopen.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Mary, are you happy with https://spreadfirefox.authstage.mozilla.com/node/3049#comments now?

Comment 9

[Mary]

Hey there:  Looking good, but two things:  These replies aren't showing up on the "recent discussions" block. Anyone else notice that?  And, should my reply be on top of the thread?  Not sure what best practice is here -- original comment followed by sequential replies or replies in order of posting.  Lemme know!

Comment 10

[Alex Buchanan [:abuchanan]]

(In reply to comment #9)
> Hey there:  Looking good, but two things:  These replies aren't showing up on
> the "recent discussions" block. Anyone else notice that?  

I made a test comment (in reply to a comment) and it showed up in the recent discussions block (after I ran cron manually), so I don't see any problem there.

> And, should my reply
> be on top of the thread?  Not sure what best practice is here -- original
> comment followed by sequential replies or replies in order of posting.  Lemme
> know!

The sort order is configurable.  I've never had a strong preference, I usually just get used to whatever system a site uses, as I frequently see it go either way.  

Having the newest comments at the top makes the newest content more readily available on the page, but forces you to read the convo. backwards if you want to get it all.

Having them in sequential order, top to bottom, makes the conversation flow, but forces you to scroll down for the most recent content.

The forums let the user choose the order, maybe this would be the best option (?), but that's a bigger task

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

We brought this up in the meeting this past week and all decided it's looking fine on staging.

Verified FIXED; if we find something we'd like to change, we should file individual bugs.