473700 - Intermittent crashtest timeouts 458637-1.html and 421715-1.html

Status: REOPENED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

REFTEST TEST-UNEXPECTED-FAIL | file:///e:/builds/moz2_slave/mozilla-central-win32-unittest/build/content/base/crashtests/458637-1.html | timed out waiting for onload to fire
REFTEST TEST-UNEXPECTED-FAIL | file:///e:/builds/moz2_slave/mozilla-central-win32-unittest/build/content/canvas/crashtests/421715-1.html | timed out waiting for onload to fire

These have been occurring frequently on Windows trunk for the last week. They always occur together. This behaviour started on 1a4e256b6894 although 458637-1.html seems to have timed out at least once before then (although definitely a lot less often). Likewise, I only see one isolated timeout of 458637-1.html on the 1.9.1 branch, so that doesn't seem to be affected.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Test 421715-1.html happens to be the one after 458637-1.html. So maybe it's getting hammered by residual effects of 458637-1.html.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I tried running the test before and after the changes around 1a4e256b6894, and I got the same performance both times, so I can't see what might have changed there.

I'll land my fix in bug 473680 to make 458637-1.html more reasonable, and then we'll see if that fixes the random orange.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

My fix seems to have stopped these tests from failing. I guess we'll leave it at that.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I spoke too soon, there have been a lot of failures recently.

Boris, you fixed 458637, any ideas spring to mind?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Not off the top of my head.  :(

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> I'll land my fix in bug 473680

Duplicate of that bug !?

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.