473715 - LDAP fails to initialise in compose window

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Chris Malton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/525.19 (KHTML, like Gecko) Chrome/1.0.154.43 Safari/525.19
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090114 Shredder/3.0b2pre

When composing mail (subsequent to nightly update to 20090113) Shredder cannot access the LDAP server for address book records.  When I start to compose mail, the following message appears under the To: field:
<LDAP initialization problem>

Clicking on it reveals the following error:

Error code 0xc1f30001: Unknown error
Please contact your System Administrator.


Reproducible: Always

Steps to Reproduce:
1. Upgrade to Shredder nightly after 20090113
2. Use an LDAP Address Book
3. Start to type the To: address for an email.
Actual Results:  
<LDAP initialization failed> appears below the address box

Expected Results:  
Search results for the part-entered address shows.

Only started since 20090113 update.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

The problem is that with the changes I did in bug 419595 we need to call init() on the nsILDAPURL. Given that we already have the full url, the simplest fix is to get the nsILDAPURL via the io service and we'll know everything is correct.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix v2

Fixes SM LDAP autocomplete properly.

Comment 5

[[e-mail]]

Comment on attachment 358163 [details] [diff] [review]
The fix v2

>+            let url =
>+              sPrefs.getComplexValue(autocompleteDirectory +".uri",
>+                                     Components.interfaces.nsISupportsString)
>+                    .data;
I know you want to wrap to 80 chars but 4 lines is a bit excessive... I'd use
var url = sPrefs.getComplexValue(autocompleteDirectory + ".uri",
    Components.interfaces.nsISupportsString).data;

Comment 6

[Mark Banner (:standard8)]

Patch checked in: http://hg.mozilla.org/comm-central/rev/1df064913853

Fix will be in tomorrow's nightlies.