473766 - Make reason for failed test more observable

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090114 Shiretoko/3.1b3pre Ubiquity/0.1.4 ID:20090114020333

When you run a test in MozMill and something fails you only see "fail :: undefined +" in the output pane. You have to expand the entry to see the real cause, e.g.

fail :: undefined +exception: TypeError: Cc['@mozilla.org/file/directory_servic;1'] is undefinedtest: function (module) {
    places.restoreDefaultBookmarks();
}

Can't we also show a meaningful description so we don't really have to expand each test entry?

Comment 1

[Adam Christian]

I'll work on this tomorrow, should be doable for 1.1

Comment 2

[Mikeal Rogers [:mikeal] (mrogers@)]

Now that we have things in HTML we should be able to do a lot more with that output object. I'm excited to see what you come up with :)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

I like the display of errors we have inside the error console. No need to expand an error. You will always see the reason. Having an error in MozMill you have to expand the node first before anything can be observed. That's bad and requires extra clicks all the way. Further we should try to reduce the output to only show the line which is causing the error and not the whole function itself. That's too much confusing and doesn't help to find the place where the real error occurred. Makes that sense?

Comment 4

[cmtalbert]

I don't think that having the errors always expanded would be a good option.  I think that it makes more sense to have a better visual indication on how to expand the errors.  Right now, most people do not understand that they can click on a + to expand an error message.

Comment 5

[cmtalbert]

Attachment: Here's my suggestion

Adam, here's something that's very simple that we could do to really solve this problem.  It makes it obvious that the user can click on these items for more information.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Clint, I don't say that I want to have the errors expanded so all the source code is displayed. I meant to only show the exception message by default. Lately when running tests during implementation it's a hassle to have to expand the nodes all the time while you aren't able to see the reason why it fails. That makes it really uncomfortable to write tests.

Comment 7

[Adam Christian]

Comment on attachment 364559 [details] [diff] [review]
Here's my suggestion

This is certainly necessary addition. Go ahead and check this in.

Comment 8

[Adam Christian]

I know exactly what Henrik means, I will address this as soon as I have some free cycles.

Comment 9

[cmtalbert]

reply to comment #7)
> (From update of attachment 364559 [details] [diff] [review])
> This is certainly necessary addition. Go ahead and check this in.
r 399, leaving bug open for you.

Comment 10

[Adam Christian]

Committed revision 405.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

That looks fantastic Adam! The only concern I have is that you really have to make long movements to expand/collapse a message. Even the looks simulates a dropdown field, it can only be opened via the little button at the right side. Shall I file a new bug for further improvement for 1.2?

Verified fixed for 1.1.