Improve diagnostics for malformed @font-face rules

RESOLVED FIXED in mozilla1.9.2a1

Status

()

defect
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: zwol, Assigned: zwol)

Tracking

Trunk
mozilla1.9.2a1
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

11 years ago
We were not diagnosing missing { } around a font-face block at all.  The patch in bug 473720 reuses two diagnostic strings phrased for regular CSS declaration blocks in the @font-face parser, because of the 1.9.1 string freeze.  This patch, for trunk only, adds new diagnostic strings specific to @font-face.  It is on top of 473720.
Attachment #357219 - Flags: superreview?(dbaron)
Attachment #357219 - Flags: review?(dbaron)
Comment on attachment 357219 [details] [diff] [review]
rev 1: add new diagnostic strings

r+sr=dbaron if you change "@font-face block" to "@font-face rule" (twice)
Attachment #357219 - Flags: superreview?(dbaron)
Attachment #357219 - Flags: superreview+
Attachment #357219 - Flags: review?(dbaron)
Attachment #357219 - Flags: review+
Assignee

Comment 2

11 years ago
Done.
Attachment #357219 - Attachment is obsolete: true
Attachment #357865 - Flags: superreview+
Attachment #357865 - Flags: review+
Assignee

Updated

11 years ago
Keywords: checkin-needed
Whiteboard: [needs landing: trunk only]
Comment on attachment 357865 [details] [diff] [review]
rev 2: "@font-face rule" instead of "@font-face block"
[Checkin: Comment 3]


http://hg.mozilla.org/mozilla-central/rev/692c543f7b55
Attachment #357865 - Attachment description: rev 2: "@font-face rule" instead of "@font-face block" → rev 2: "@font-face rule" instead of "@font-face block" [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing: trunk only]
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.