Closed
Bug 473815
Opened 16 years ago
Closed 15 years ago
Improve diagnostics for malformed @font-face rules
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: zwol, Assigned: zwol)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.26 KB,
patch
|
zwol
:
review+
zwol
:
superreview+
|
Details | Diff | Splinter Review |
We were not diagnosing missing { } around a font-face block at all. The patch in bug 473720 reuses two diagnostic strings phrased for regular CSS declaration blocks in the @font-face parser, because of the 1.9.1 string freeze. This patch, for trunk only, adds new diagnostic strings specific to @font-face. It is on top of 473720.
Attachment #357219 -
Flags: superreview?(dbaron)
Attachment #357219 -
Flags: review?(dbaron)
Comment on attachment 357219 [details] [diff] [review] rev 1: add new diagnostic strings r+sr=dbaron if you change "@font-face block" to "@font-face rule" (twice)
Attachment #357219 -
Flags: superreview?(dbaron)
Attachment #357219 -
Flags: superreview+
Attachment #357219 -
Flags: review?(dbaron)
Attachment #357219 -
Flags: review+
|
Assignee | |
Comment 2•16 years ago
|
||
Done.
Attachment #357219 -
Attachment is obsolete: true
Attachment #357865 -
Flags: superreview+
Attachment #357865 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing: trunk only]
|
||
Comment 3•15 years ago
|
||
Comment on attachment 357865 [details] [diff] [review] rev 2: "@font-face rule" instead of "@font-face block" [Checkin: Comment 3] http://hg.mozilla.org/mozilla-central/rev/692c543f7b55
Attachment #357865 -
Attachment description: rev 2: "@font-face rule" instead of "@font-face block" → rev 2: "@font-face rule" instead of "@font-face block"
[Checkin: Comment 3]
|
|
||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing: trunk only]
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•