473831 - Need libnotify dev headers installed on Linux tinderboxes and build machines

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Michael Ventnor]

Bug 469880 added support for using libnotify to send system-level notifications from Firefox on Linux, in the same vein as Growl on OS X. It isn't turned on yet because the development headers for libnotify aren't available on the build machines. Would really like the libnotify headers and their pkgconfig entry to be available so I can start turning this on by default.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

What timeline are you looking for here ? Do you want that patch included in 3.1b3 ?

Comment 2

[Michael Ventnor]

I don't think the patch has priority on 3.1. I was only aiming to get this happening on the mozilla-central boxes (and maybe the tryservers if they're separate).

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Ok. The machines for m-c come from a pool that also does m-1.9.1 and tracemonkey, so they all those branches would support it at the same time. try server are separate pool but the same reference platform, so no big deal.

We have libnotify-0.4.2-6.el5 on there currently, so I guess you're asking for libnotify-devel-0.4.2-6.el5. Just want to check you're not relying on features in newer releases of libnotify.

Comment 4

[Michael Ventnor]

Yes, 0.4.2-devel would be just fine, thanks.

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #3)
> Ok. The machines for m-c come from a pool that also does m-1.9.1 and
> tracemonkey, so they all those branches would support it at the same time. 

I note its the same version of libnotify, just extra headers, and from the description it sounds like this change would be invisible to the mozilla-1.9.1 builds unless they landed code to explicitly call it. For sanity sake, I'll ask the obvious questions: 

- is it safe to make this change on machines that also build mozilla-1.9.1?
- is this something that needs 1.9.1 approval?

Comment 6

[Reed Loden [:reed]]

(In reply to comment #5)
> - is it safe to make this change on machines that also build mozilla-1.9.1?

It's just development headers, so, yes, it's fine.

> - is this something that needs 1.9.1 approval?

Adding the headers? No, I wouldn't think so. Not sure why that would make sense anyway for something that doesn't affect the builds in any way if the code isn't there.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I checked the devel rpm and there's nothing in there that'll stomp on anything else on the machines. Going to move ahead with installing this on the linux slave pool.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Fixed.

Steps:
yumdownloader libnotify-devel-0.4.2-6.el5
rpm -ivh libnotify-devel-0.4.2-6.el5.i386.rpm
yum list installed | grep libnotify
 libnotify.i386                 0.4.2-6.el5            installed       
 libnotify-devel.i386           0.4.2-6.el5            installed       

This worked for moz2-linux-slave01,04 thru 16, try-linux-slave01/02/03, and the ref platform CentOS-5.0-ref-tools-vm.

moz2-linux-slave02/03 didn't have yum-utils installed, so I did 
wget http://vault.centos.org/5.1/os/i386/CentOS/yum-utils-1.0.4-3.el5.centos.2.noarch.rpm 
rpm -ivh yum-utils-1.0.4-3.el5.centos.2.noarch.rpm
Done this way to match other machines, and because "yum install yum-utils" adds ~ 4 packages and leads to the situation below.

moz2-linux-slave04/06 had more recent versions of yum and yum-utils
  yum        - 3.2.8-9-el5.centos2.1   vs  3.0.5-1.el5-centos.2 in ref plat
  yum-utils  - 1.1.10-9.el5.centos     vs  1.0.4-3.el5.centos.2 in ref plat

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

And came back to get the 64bit slave too:

[cltbld@moz2-linux64-slave01 ~]$ yum list installed | grep libnotify
libnotify.x86_64                         0.4.2-6.el5            installed       
libnotify-devel.x86_64                   0.4.2-6.el5            installed