Closed Bug 473908 Opened 17 years ago Closed 17 years ago

Too much recursion in nsCSSSelector::CalcWeight with lots of ":not()"

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: jruderman, Assigned: dbaron)

References

Details

(Keywords: crash, testcase)

Attachments

(2 files)

I'm not sure how to reproduce this without "ulimit -s", since the parser gets really slow with larger input (possibly n^2).
ulimit -s 100 is not such a great idea if you're going to browse Bugzilla, since hunspell assumes you have a little more stack space than that. ulimit -s 300 is better.
Assignee: nobody → dbaron
Attached patch patchSplinter Review
No crashtest (I haven't actually even tested the crash, but it fixes the problem described), but I did add some related mochitests to test_cascade.html.
Attachment #357435 - Flags: superreview?(bzbarsky)
Attachment #357435 - Flags: review?(bzbarsky)
Attachment #357435 - Flags: superreview?(bzbarsky)
Attachment #357435 - Flags: superreview+
Attachment #357435 - Flags: review?(bzbarsky)
Attachment #357435 - Flags: review+
Status: NEW → RESOLVED
Closed: 17 years ago
OS: Mac OS X → All
Priority: -- → P4
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: