Closed Bug 473921 Opened 15 years ago Closed 15 years ago

Venkman and ChatZilla packaging in L10n builds busted

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a3

People

(Reporter: wladow, Assigned: kairo)

Details

Attachments

(2 files)

Venkman (and Chatzilla ?) packaging is probably busted (L10n builds):

- windows installer doesn't contain (install) venkman extension, just its langpack
- for locales not defined in venkman's all-locales installer contains langpack-<locale>@venkman.mozilla.org with en-us files, f.e. in hu version it is extensions\langpack-hu@venkman.mozilla.org\chrome\venkman.jar\locale\en-US\
- .zip and .bz2 packages for locales defined in all-locales contain langpacks for all the locales defined in all-locales (applies to chatzilla as well)
- .zip and .bz2 packages for locales not defined in all-locales contain langpacks for other locales, f.e. seamonkey-2.0a3pre.hu.win32.zip contains French langpacks for both ChatZilla and Venkman
Assignee: build-config → kairo
Summary: Venkman packaging in L10n builds busted → Venkman and ChatZilla packaging in L10n builds busted
Target Milestone: --- → seamonkey2.0a3
(In reply to comment #0)
> Venkman (and Chatzilla ?) packaging is probably busted (L10n builds):
> 
> - windows installer doesn't contain (install) venkman extension, just its
> langpack

http://cb-sea-linux-tbox.sj.mozilla.com:8010/builders/Win2k3%20comm-central%20l10n/builds/2290/steps/compile_23/logs/stdio looks like it's actually packaging both venkman and chatzilla themselves as well as the Chatzilla langpack (no sk in venkman all-locales).

http://cb-sea-linux-tbox.sj.mozilla.com:8010/builders/Win2k3%20comm-central%20l10n/builds/2290/steps/compile_21/logs/stdio which has also a venkman langpack, also looks good in this regard, I see venkman.jar et al being packed into the installer in the log.

> - for locales not defined in venkman's all-locales installer contains
> langpack-<locale>@venkman.mozilla.org with en-us files, f.e. in hu version it
> is extensions\langpack-hu@venkman.mozilla.org\chrome\venkman.jar\locale\en-US\

I don't see any "langpack-hu" other the main SeaMonkey one appearing in http://cb-sea-linux-tbox.sj.mozilla.com:8010/builders/Win2k3%20comm-central%20l10n/builds/2290/steps/compile_10/logs/stdio

> - .zip and .bz2 packages for locales defined in all-locales contain langpacks
> for all the locales defined in all-locales (applies to chatzilla as well)
> - .zip and .bz2 packages for locales not defined in all-locales contain
> langpacks for other locales, f.e. seamonkey-2.0a3pre.hu.win32.zip contains
> French langpacks for both ChatZilla and Venkman

Right, I see that, we don't clean up those correctly right now, missed them when we switched to not killing and recreating the whole en-US build for every locale. Patch upcoming.
(In reply to comment #1)
> http://cb-sea-linux-tbox.sj.mozilla.com:8010/builders/Win2k3%20comm-central%20l10n/builds/2290/steps/compile_23/logs/stdio
> looks like it's actually packaging both venkman and chatzilla themselves as
> well as the Chatzilla langpack (no sk in venkman all-locales).
> 
> http://cb-sea-linux-tbox.sj.mozilla.com:8010/builders/Win2k3%20comm-central%20l10n/builds/2290/steps/compile_21/logs/stdio
> which has also a venkman langpack, also looks good in this regard, I see
> venkman.jar et al being packed into the installer in the log.
> 

The install log from the latest sk win installer:

>-------------------------------------------------------------------------------
> Installing JavaScript Debugger
>-------------------------------------------------------------------------------
>   Installed File: C:\Program Files\SeaMonkey\extensions\langpack-sk@venkman.mozilla.org\chrome.manifest
>   Installed File: C:\Program Files\SeaMonkey\extensions\langpack-sk@venkman.mozilla.org\install.rdf
>   Installed File: C:\Program Files\SeaMonkey\extensions\langpack-sk@venkman.mozilla.org\components\venkman-service.js
>   Installed File: C:\Program Files\SeaMonkey\extensions\langpack-sk@venkman.mozilla.org\chrome\venkman.jar

this means it doesn't install venkman, just the langpack, in this case filled with en-US files. I can take a look at installer's script later tonight, if needed.
Here's a patch for cleaning up chatzilla and venkman langpacks so we don't repackage those of previously processed locales into packages done later in a multi-locale buildbot cycle.
Attachment #361791 - Flags: review?(l10n)
(In reply to comment #2)
> this means it doesn't install venkman, just the langpack, in this case filled
> with en-US files. I can take a look at installer's script later tonight, if
> needed.

Erm, that looks like an installer error, it seems to install the venkman extension itself into the directory where the langpack would be if one would exist. Frank, did you or Robert mess something up with the recent large installer changes?
Attachment #361791 - Flags: review?(l10n) → review+
Attached patch fix installerSplinter Review
- fixes the bug where installer is actually installing venkman's langpack instead of venkman itself
Attachment #361797 - Flags: review?(bugzilla)
Hm, the change at that time was only http://hg.mozilla.org/comm-central/rev/963289aacfa3#l2.493. It copied over the old code to some new macro. Maybe another change was involved then.
Actually I meant http://hg.mozilla.org/comm-central/rev/963289aacfa3#l2.564 and yes, that looks like a bug.
Attachment #361797 - Flags: review?(bugzilla) → review+
Pushed as http://hg.mozilla.org/comm-central/rev/4b89093b6cc8 and http://hg.mozilla.org/comm-central/rev/da38e5d526e0 - thanks for reporting, patching and reviewing!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.