Drop support for window.directories

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.3a5
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

8 years ago
window.directories in Gecko returns the same [BarProp] object as window.personalbar. No other browser supports it. Unless support for this is needed, we should drop it. If support is needed, please let me know so I can add it to the spec.
(Assignee)

Comment 1

7 years ago
Created attachment 432351 [details] [diff] [review]
Fix
Attachment #432351 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
(Assignee)

Comment 2

7 years ago
Created attachment 432352 [details] [diff] [review]
Fix with new uuid
Attachment #432351 - Attachment is obsolete: true
Attachment #432352 - Flags: review?(bzbarsky)
Attachment #432351 - Flags: review?(bzbarsky)
Comment on attachment 432352 [details] [diff] [review]
Fix with new uuid

Stealing review. r=jst
Attachment #432352 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
What about dom.disable_window_open_feature.directories?
(Assignee)

Comment 5

7 years ago
(In reply to comment #4)
> What about dom.disable_window_open_feature.directories?

Something else entirely, it's related to window.open(). Hixie actually wants to drop all support for the features argument, so I'd rather not spend time on it.

(Note: Used in <http://mxr.mozilla.org/mozilla-central/source/embedding/components/windowwatcher/src/nsWindowWatcher.cpp#1501>.)
(In reply to comment #5)
> (In reply to comment #4)
> > What about dom.disable_window_open_feature.directories?
> 
> Something else entirely, it's related to window.open().

So is window.directories, except that it exposes the state while the directories argument allows setting it. directories=... duplicates personalbar=... just like window.directories duplicates window.personalbar. Keeping both things in sync in seems only logical, regardless of any future plans to drop all feature arguments.
(Assignee)

Comment 7

7 years ago
Created attachment 445103 [details] [diff] [review]
Remove argument to window.open and pref

Fair enough.
Attachment #445103 - Flags: review?(jst)
Attachment #445103 - Flags: feedback?(dao)

Updated

7 years ago
Attachment #445103 - Flags: review?(jst) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [c-n:445103]
(Assignee)

Updated

7 years ago
Whiteboard: [c-n:445103] → [c-n:432352,445103]
Comment on attachment 445103 [details] [diff] [review]
Remove argument to window.open and pref

Don't think my feedback is needed here beyond what I said in my previous comment...
Attachment #445103 - Flags: feedback?(dao)
(Assignee)

Comment 9

7 years ago
Created attachment 445651 [details] [diff] [review]
Patch for checkin

Merged to tip. r=jst.
Attachment #432352 - Attachment is obsolete: true
Attachment #445103 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Whiteboard: [c-n:432352,445103]
does not apply cleanly here, can you provide an updated patch please?
http://hg.mozilla.org/mozilla-central/rev/e0a9a9ea63f1
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5

Updated

7 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 12

7 years ago
I added a note to <https://developer.mozilla.org/en/Upcoming_Firefox_features_for_developers#Miscellaneous_DOM_changes> and removed it from <https://developer.mozilla.org/en/DOM%3awindow.open>. Is any more documentation needed?
https://developer.mozilla.org/en/DOM%3awindow.open used to say:

"directories: [...] in MSIE 5+, it renders the Links bar. [...] personalbar: Same as directories but only supported by Netscape and Mozilla-based browsers."

Was that incorrect?

Comment 14

7 years ago
You should not remove information from MDC as long as older browser versions are in use. People may use obsolete features or search for info why it doesn't work.
  
I propose:

https://developer.mozilla.org/en/DOM/window#Properties
Add an obsolete-inline template

https://developer.mozilla.org/En/DOM/Window.directories
Add an obsolete-header template,
mention the Gecko/Firefox version which dropped it,
recommend use of "window.personalbar" instead,
(perhaps link to this bug if you think it's helpful).
(Assignee)

Comment 15

7 years ago
Apparently IE doesn't support any of the BarProp objects, but up to IE6, it did support the directories feature to window.open. (See also <http://msdn.microsoft.com/en-us/library/ms536651%28VS.85%29.aspx>.) (WebKit seems to ignore the features, and support only the personalbar object. Opera seems to support neither the features nor any BarProp objects.)

Made changes to
https://developer.mozilla.org/en/DOM/window.open
https://developer.mozilla.org/en/DOM/window#Properties
https://developer.mozilla.org/En/DOM/Window.directories

Updated

7 years ago
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Updated

7 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.