474159 - test_notifications.html and test_prompt.html mochitests fail: "notifyBox is undefined"

Status: VERIFIED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090117 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/a3abe1807f71 + bug 446300 patch
 +http://hg.mozilla.org/comm-central/rev/da4ab57196d6 + bug 446300 patch)

{
74037 INFO Running /tests/toolkit/components/passwordmgr/test/test_notifications.html...
74038 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Access Ci
74039 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Access Cc
74040 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Access pwmgr
74041 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Access prefs
74042 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Access pref branch
74043 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Got notification box
74044 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Error thrown during test: notifyBox is undefined - got 0, expected 1
74045 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications.html | Ignoring load of subtest #undefined
}

Comment 1

[Serge Gautherie (:sgautherie)]

Same error with test_prompt.html
{
74050 INFO Running /tests/toolkit/components/passwordmgr/test/test_prompt.html...
74051 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Access Ci
74052 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Access Cc
74053 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Access Cc[@mozilla.org/passwordmanager/authpromptfactory;1]
74054 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Access Ci.nsIPromptFactory
74055 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_prompt.html | promptFac getService()
74056 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Got notification box
74057 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_prompt.html | Error thrown during test: notifyBox is undefined - got 0, expected 1
}

Comment 2

[Justin Dolske [:Dolske]]

Presumably SeaMonkey's getNotificationBox() implementation in navigator.js is returning null.

Comment 3

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/search?string=getNotificationBox&case=on&find=%2Fsuite%2F

Comment 4

[[e-mail]]

Attachment: Proposed patch

So, after reading notification_common.js the problem is that nsLoginManagerPrompter.js hands an XPCNativeWrapped object window to getNotificationBox but the tests don't. This works around the problem by ensuring a wrappedJSObject always exists for the notification box.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 357571 [details] [diff] [review]
Proposed patch

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090117 SeaMonkey/2.0a3pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/a3abe1807f71 + bug 446300 patch
 +http://hg.mozilla.org/comm-central/rev/da4ab57196d6 + bug 446300 patch)

This patch fixes these two tests;
and doesn't regress anything in |--test-path=toolkit/components/passwordmgr/test|.

Comment 6

[Serge Gautherie (:sgautherie)]

Now that the SM/1.9.1 boxes run the tests again, we can see that they have this bug too.

Comment 7

[[e-mail]]

Pushed changeset d4ed6abeecb3 to comm-central.

Comment 8

[Serge Gautherie (:sgautherie)]

V.Fixed, per tinderboxes.