474257 - SVG SMIL: Update beginElement & co. to return void

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Brian Birtles (:birtles)]

The specifications for the DOM TimeElementControl interface differ between SVG and SMIL Animation. This discrepancy has been addressed in an erratum to SVG 1.1

http://www.w3.org/2003/01/REC-SVG11-20030114-errata#elementtimecontrol-interface

However, some of how code has not been migrated from the old signature (with a boolean return type) to the new (with a void return type). We need to bring this all up to date.

Furthermore, we have a mochitest (test_smilRestart.xhtml) that is failing because it relies on this boolean return type that we no longer offer.

Comment 1

[Brian Birtles (:birtles)]

Attachment: patch v1a

Patch to address these issues

Comment 2

[Brian Birtles (:birtles)]

Note, this patch applies on top of the patch for bug 473702 (implement SVGAnimationElement interface) because we need that interface in the updated mochitest now that we can't use the return value of BeginElement and co.

Comment 3

[Brian Birtles (:birtles)]

Attachment: patch v1b

Fixed return types in nsSMILTimedElement.cpp (thanks Robert!)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed d9bbceb06cdc

Comment 5

[Eric Shepherd [:sheppy]]

Given that we currently don't explicitly document SVG at all, I'm removing the doc needed keyword from this in favor of bug 602022, which covers writing a complete set of SVG documentation.