474294 - Support aria-expanded on more roles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The spec now has an expanded list of roles that aria-expanded can be used on:
http://www.w3.org/WAI/PF/aria/#aria-expanded

It applies to almost everything, including landmarks, which currently aren't in the state map. The best thing for now is to just move aria-expanded to the universal state map in nsARIAMap.cpp.

At some point we're going to need to provide some constraints on the universal (global) states anyway, and at that point we can refactor the ARIA support a bit. (This relates to Henri's proposal that there are HTML elements which inherit ARIA roles).

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: my 10 minute WIP - for discussion

Aaron, is this the idea? (Note: mochitests pass)

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Shall we move landmarks into the state map on this bug?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 357716 [details] [diff] [review]
my 10 minute WIP - for discussion

Marco, if you are also happy with this feel free to push to trunk, thanks.

Comment 4

[Aaron Leventhal]

(In reply to comment #2)
> Shall we move landmarks into the state map on this bug?

How do you mean? Make a state map for landmarks? Interesting idea.

Let's not do any major factoring until we know how we're dealing with ARIA in HTML:
Strong semantics that don't take ARIA
Weak semantics that can take ARIA, and may have a default role, or allow certain ARIA properties to be used which are not already global.

Comment 5

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/fae62c15f9a0

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 357716 [details] [diff] [review]
my 10 minute WIP - for discussion

ARIA 1.0 compliance.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

A major AT vendor really wants this... I recommend this one for 1.9.1 as well.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 357716 [details] [diff] [review]
my 10 minute WIP - for discussion

a191=beltzner

Comment 9

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4f61ba8f68f3

Comment 10

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)