474297 - use post_upload.py for en-US dep/nightly builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

We landed post_upload.py for l10n and release builds in bug 455578. We should flip over en-US dep/nightly builds in order to be consistent, and get some better testing. There's already been some bustage on the l10n nightlies that would've been caught earlier if en-US builds were using the same system.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: move en-US nightlies to upload target/post_upload.py - buildbotcustom patch

NightlyBuildFactory is the most important stuff here. I've added logic that generates the proper post_upload.py command, and then calls out to the upload target. This has been tested for both dep and nightly builds and works fine.

I moved productName out of ReleaseBuildFactory since Nightly builds depend on it now, too.

This gets rid of all of our usage of MozillaStageUpload, which is great. I'd like to get rid of SetMozillaBuildProperties, too, but I think that's going to need some Makefile hacking to get a simple way to print out the BuildID. I filed bug 475382 on this.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: move en-US nightlies to upload target/post_upload.py - master-side patch

Dead simple patch. Just adds productName to the configuration dict and passes it to NightlyBuildFactory.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: post_upload.py fixes for en-US nightly uploading

This patch fixes a few bugs that weren't caught in the original testing:
* try/finally statement around symlink generation. Can't use try/except/finally because post_upload.py is called with Python 2.3 on staging-stage. All I'd do is re-raise the exception anyways, so no big deal.
* Reject MAR files for tinderbox builds directories. It's not the greatest thing to do this here, but it's better than adding a second upload target or otherwise mucking around to not even pass them post_upload.py IMHO.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 358885 [details] [diff] [review]
post_upload.py fixes for en-US nightly uploading

changeset:   38:a16c40591252

I updated the checkouts on staging-stage and stage.m.o, too.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: post-upload master side, staging+production

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 359600 [details] [diff] [review]
post-upload master side, staging+production

changeset:   710:b8b8019d7ace

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 358883 [details] [diff] [review]
move en-US nightlies to upload target/post_upload.py - buildbotcustom patch

changeset:   181:baf292596907

Comment 8

[[e-mail] (:bhearsum)]

This changed landed without issue.