Closed
Bug 474315
Opened 15 years ago
Closed 15 years ago
Personalized Tags are not taken into account properly by filters
Categories
(MailNews Core :: Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: andre, Assigned: rkent)
Details
Attachments
(1 file)
591 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5 Build Identifier: ersion 2.0.0.19 Created associated new tags (“a” and “b”) & filters (“a filter” and “b filter”) with the filters checking that email has been both answered and that it is tagged, to move the message to the folder (“a folder” and “b folder”) associated with the tag. However if I run the filter list then any message with one of the new tags will react to the filter at the top of the list as if the filter was not discriminating between the tag “a” and “b” (however it does seem to discriminate between any of the embedded tag (“important” to “later” for instance) and my new personalized tags. Reproducible: Always Steps to Reproduce: 1. Create "folder a", "folder b" and "folder Work" in "Local Folders" 2. Create Tags “a”, "b" and "work" 3. create "Filter Work” - if message status = replied - and - if message tag = Work - then move to "folder Work" 4. Create Filter “a” - if message status = replied - and - if message tag = a - then move to "folder a" 5. create Filter “b” - if message status = replied - and - if message tag = b - then move to "folder b" 6. ("Filter b" is above "Filter a" which is above "Filter Work" in the list) 7. Label 1 message in your inbox with "work" & reply to it so it is marked "replied" 8. Label 1 message in your inbox with "a" & reply to it so it is marked "replied" 9. Label another message in your inbox with "b" & reply to it so it is marked "Replied" 10. Run filters Actual Results: both tagged messages "a" and "b" are moved to "folder b" tagged message "work" is moved to "folder work" Expected Results: message tagged "a" should be moved to "a folder" message tagged "b" should be moved to "b folder" message "work" is properly moved to "folder work" - Swap filter "a" and "b" in the list to have "a Filter" above "b Filter" in the list and both messages "a" & "b" will be moved to "folder a" - As a aside, I cannot delete or alter the new tags (neither their name, nor number and colour) - If I move tagged message from "Local Folder" to "inbox" the tagged is not displayed any more but it seems to remain active... :/
Product: Calendar → Thunderbird
Hardware: Other → PowerPC
Version: unspecified → 2.0
Updated•15 years ago
|
QA Contact: general → general
Assignee | ||
Comment 1•15 years ago
|
||
I can reproduce this in trunk - but for reasons that are quite different than the reporter's interpretation. Tracing out the issues, we have at http://mxr.mozilla.org/comm-central/source/mailnews/base/search/src/nsMsgLocalSearch.cpp#184 : if (result ^ isAnd) But ^ is a bitwise operator, not a logical operator. In this case, result=2 and isAnd=1, so the logical result should be false, but the bitwise result is true. I'm going to assume that this is the actual bug, so I'll hijack this, attach a patch, and we'll call it fixed on trunk. I won't change the description yet to give the reporter a chance to object. A better description would be "Message Status Replied (and others?) always ORs with other filter terms"
Status: UNCONFIRMED → ASSIGNED
Component: General → Search
Ever confirmed: true
Product: Thunderbird → MailNews Core
QA Contact: general → search
Version: 2.0 → Trunk
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #357728 -
Flags: superreview?(bienvenu)
Attachment #357728 -
Flags: review?(bienvenu)
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → kent
Assignee | ||
Updated•15 years ago
|
Whiteboard: [waiting review bienvenu]
Target Milestone: --- → Thunderbird 3.0b2
Assignee | ||
Comment 3•15 years ago
|
||
Bienvenu, this is a simple patch, so don't let if fall off of your review radar.
Comment 4•15 years ago
|
||
yes, it's on my radar - I just need to recreate the bug so I can test the fix.
Updated•15 years ago
|
Attachment #357728 -
Flags: superreview?(bienvenu)
Attachment #357728 -
Flags: superreview+
Attachment #357728 -
Flags: review?(bienvenu)
Attachment #357728 -
Flags: review+
Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•