Closed
Bug 474330
Opened 17 years ago
Closed 7 years ago
nativegen.py-generated thunks need to unbox receivers
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
WONTFIX
Future
People
(Reporter: stejohns, Unassigned)
Details
Attachments
(1 file)
|
51.04 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
Old MIR-generated thunks cleared the atom-type bits on the receiver, as there were code paths where a raw atom are possible. New thunks need to do this too.
Attachment #357709 -
Flags: review?(edwsmith)
|
Reporter | |
Comment 1•17 years ago
|
||
Note, in theory this is needed when a class overrides an Object-based native method and then is called via an Atom-typed var; XML.hasOwnProperty is a good example. In practice I haven't yet found a test case that will repro in avmshell alone (bug was found in Flash integration) but fix is clearly necessary -- followup work should identify an exact testcase however.
|
|
||
Updated•17 years ago
|
Flags: in-testsuite?
|
|
||
Comment 2•17 years ago
|
||
Comment on attachment 357709 [details] [diff] [review]
Patch
patch looks fine, lets leave this open until we either have a test case why masking is needed, or a remove the masking
Attachment #357709 -
Flags: review?(edwsmith) → review+
|
|
Reporter | |
Comment 3•17 years ago
|
||
agreed on leaving open for now. pushed patch as changeset: 1317:197b599266f9
|
|
||
Updated•16 years ago
|
Target Milestone: --- → Future
Flags: flashplayer-qrb+
Flags: flashplayer-injection-
Flags: flashplayer-bug-
|
||
Comment 4•7 years ago
|
||
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
|
|
||
Comment 5•7 years ago
|
||
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in
before you can comment on or make changes to this bug.
Description
•