474340 - Change aria-grab to aria-grabbed

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

aria-grab has been changed to aria-grabbed and been given values that are more consistent with things like expanded/checked/pressed/selected.

Currently:  aria-grab, mapped to "grab" object attribute
  true:Indicates that the element has been "grabbed" for dragging. 
  supported:Indicates that the element supports being dragged. 
  false:Indicates that the element does not support being dragged. 

Proposed:  aria-grabbed, mapped to "grabbed" object attribute
  true: element has been grabbed 
  false: element has not been grabbed (but is grabbable) 
  undefined (default): element is not grabbable, same as attribute not present or ""

In addition, for backwards-compat, we should still expose grab attribute as we did before. 
We should map aria-grabbed values to "grab" as follow:
  true->true
  false->supported
  undefined,"" or not present->false

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Do we really want to still support the deprecated way? If so, let's do it in a way that can be easily removed later.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

I'll give this one a shot.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Wow, the user agent implementation guide doesn't currently talk about grab* at all. (http://www.w3.org/WAI/PF/aria-implementation/)

I'm wondering if this is all dhtml author managed or if we need to do something ourselves.

Aaron, adding the aria_grabbed atom is easy, and it is only used when looking for our sort of "last chance" reasons to build accessibles in nsAccessibilityService::GetAccessible (see also HasUniversalAriaProperty).

If you can tell me why we need backwards compat, I'll try to figure out where to do the mapping from one aria attribute to another.

Comment 4

[Aaron Leventhal]

It's all author-managed.

The UA guide doesn't need to say something about it, because it talks about what to do about generic attributes (map the to object attributes minus the aria- prefix and for NMTOKEN treat "undefined" as not present). Or at least I hope it says those things -- please check.

We need backwards compat for JAWS 10, but if neither Dojo nor anything else we can find uses aria-grab then I'm game for skipping backwards-compat.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: simple fix.

Thanks Aaron, I would much rather go with simplicity, and consider backwards compat if someone asks for it.

Comment 6

[Aaron Leventhal]

So there's some outreach necessary then.

Otherwise people just discover it (or don't) when we ship and their code breaks. The main ones I'd be concerned with are YUI, JQuery UI, GWT and Dijit.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

OK. I've done some outreach and this patch can be pushed. We can add backwards compat if others ask for it, thanks.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #4)
> The UA guide doesn't need to say something about it, because it talks about
> what to do about generic attributes (map the to object attributes minus the
> aria- prefix and for NMTOKEN treat "undefined" as not present). Or at least I
> hope it says those things -- please check.

It does.

Comment 9

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/3e0f3d82822d

Comment 10

[Marco Zehe (:MarcoZ)]

Comment on attachment 360726 [details] [diff] [review]
simple fix.

ARIA 1.0 change.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 360726 [details] [diff] [review]
simple fix.

a191=beltzner

Comment 12

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ddf10d23da1c

Comment 13

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)