remove and rename calendar-decorated panes

VERIFIED FIXED in 1.0b1

Status

VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: berend.cornelius09, Assigned: berend.cornelius09)

Tracking

unspecified
1.0b1

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
With the integration of Bug 468420 -  Consolidation of the navigation bar the following decorated panes should be renamed (see also bug 468420 comment #15):
calendar/calendar-decorated-day-view
calendar/calendar-decorated-week-view
calendar-decorated-multiweek-view
calendar/calendar-decorated-month-view

The following bindings should be merged into the current calendar-multiday-view binding and calendar-month-view-binding:
-calendar-decorated-month-view-parent
-calendar-decorated-multiday-base-view
(Assignee)

Comment 1

10 years ago
Created attachment 357737 [details] [diff] [review]
patch v. #1

first patch that I want to test before I will ask for review. Within this patch I have almost only moved code and renamed bindings and have only done other code changes where it was really necessary (despite from adapting some source code comments).
Assignee: nobody → Berend.Cornelius
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Attachment #357737 - Flags: review?(philipp)
(Assignee)

Comment 2

10 years ago
Comment on attachment 357737 [details] [diff] [review]
patch v. #1

I could not detect any bad impact of the patch so I am asking for review.
Comment on attachment 357737 [details] [diff] [review]
patch v. #1

Looks good to me, r=philipp
Attachment #357737 - Flags: review?(philipp) → review+
(Assignee)

Comment 4

10 years ago
patches pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/848ca565d94e
http://hg.mozilla.org/comm-central/rev/9e051408695e
http://hg.mozilla.org/comm-central/rev/f491e73f7923

-> fixed!
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Target Milestone: --- → 1.0
(Assignee)

Comment 5

10 years ago
Created attachment 359026 [details] [diff] [review]
patch v. #2

Reopening patch. There are two boxes with a lightgrey background in the week-view above the time-scale and the scrollbox. The background-color should be white of course.
Attachment #359026 - Flags: review?(philipp)
(Assignee)

Updated

10 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #359026 - Flags: review?(philipp) → review+
(Assignee)

Comment 6

10 years ago
pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/2e75cd634b87

-> fixed
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED

Comment 7

10 years ago
Checked in lightning and sunbird build 20090128 -> VERIFIED.
Status: RESOLVED → VERIFIED
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.