474373 - Cannot Re-Open a Browser Window if MozMill is Open

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Aakash Desai [:aakashd]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090104 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090104 Minefield/3.2a1pre

After closing a browser while editing a test case in Mozmill, I wasn't able to open a new browser through any means. This includes starting a new test case using the controller.open() command.

Reproducible: Always

Steps to Reproduce:
1. Open Mozmill
2. Close all open browsers
3. Try opening a new browser window through any standard approach (File menu, Ctrl/Cmd+N, Run Editor with a Controller.open() command)
Actual Results:  
A browser window does not open.

Expected Results:  
A browser window should be able to open at any time whether Mozmill is in the middle of a test run or it isn't.

This issue is found on Shiretoko 3.1b3pre as well.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yeah. We should add a new menu item for that. Adam, do you have a free cycle?

Comment 2

[Adam Christian]

Is there any kind of exception thrown during all this? I will have some time to debug this in the morning.

Comment 3

[Aakash Desai [:aakashd]]

This is the warning that sprung up in the error console after closing my last browser window.


Warning: Error in parsing value for 'overflow'.  Declaration dropped.
Source File: chrome://mozmill/content/mozmill.xul
Line: 0

Comment 4

[Adam Christian]

Added a file menu with an accel+n to open a new window, Committed revision 323.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry but "File | New Window" doesn't work for me with r328. There are no errors displayed in the error console. I tested with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090128 Minefield/3.2a1pre

Comment 7

[Adam Christian]

We don't have a high level file menu now, but you can use cmd+n to open a new browser window. I don't know how to add a high level file menu to make this work now that we aren't in xul overlay land so I am handing this off to Clint.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Cmd/Ctrl+N should be used as a shortcut to open a new test file instead of open a new browser window. That interferes with the guidelines. We should better find a new shortcut to open up a new browser window.

Comment 9

[Adam Christian]

cmd/ctrl+n opens a new browser window in every other window, seems like people expect that behavior.. but desktop apps use cmd/ctrl+n to create a new file, design decision up to clint/mikeal.

Comment 10

[Mikeal Rogers [:mikeal] (mrogers@)]

i think we have to change the newfile shortcut to something else if this is actually prohibiting use from being able to open a browser window if all other windows are closed.

Comment 11

[Adam Christian]

Currently cmd+n will open a new browser window regardless if any are open or not. Opening a new window is currently cmd+b (for open a blank file). I think we should leave it as it is, because anything other than cmd+n to open a new window is confusing and goes against the norm.

Comment 12

[Mikeal Rogers [:mikeal] (mrogers@)]

cmd+n opens a new browser window in the rest of the app, it'll do so in the mozmill window as well.