Remove role="description"

RESOLVED FIXED in mozilla1.9.1b4

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Aaron Leventhal, Assigned: davidb)

Tracking

(Blocks: 1 bug, {access, verified1.9.1})

unspecified
mozilla1.9.1b4
x86
All
access, verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
This role is unnecessary and has been removed from ARIA. The same information is provided via aria-describedby pointing at an element.

We only need to make sure that we create an accessible object when something is pointed to via describedby. We usually do, because of the code at
http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1258

However, to get this right in all cases we need the inverse relations cache from bug 381599.

In any case, we need to remove it now since it's no longer part of ARIA.
(Reporter)

Comment 1

10 years ago
Need to update the testcase page and examples as well.
Aaron, just to be clear this bug can be fixed before bug 381599, correct?
(Reporter)

Comment 3

10 years ago
(In reply to comment #2)
> Aaron, just to be clear this bug can be fixed before bug 381599, correct?

Yes, and should.
OK taking.
Assignee: nobody → david.bolter
Status: NEW → ASSIGNED
Created attachment 360571 [details] [diff] [review]
easy fix

All tests pass (I guess we didn't have one for role="description"). I looked through remaining code for other usage but couldn't find any.
Attachment #360571 - Flags: review?(marco.zehe)

Updated

10 years ago
Attachment #360571 - Flags: review?(marco.zehe) → review+
Created attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

Thanks Surkov, it is good to make these changes even if they were harmless. The rest of [grep -Ri "\"description" accessible] looks fine. Note I touched an idl here but didn't change API so no new uuid :)
Attachment #360571 - Attachment is obsolete: true
Attachment #360733 - Flags: review?(marco.zehe)

Comment 8

10 years ago
Comment on attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

Yep, "note" is the best role in substitution I believe. Thanks!
Attachment #360733 - Flags: review?(marco.zehe) → review+

Comment 9

10 years ago
Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/42a0ae473913
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 10

10 years ago
Comment on attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

ARIA 1.0 cleanup, no risk.
Attachment #360733 - Flags: approval1.9.1?
It appears that this documentation has been migrated elsewhere.  Unless someone disagrees, I'm inclined to remove the doc-needed tag here.
(In reply to comment #11)
> It appears that this documentation has been migrated elsewhere.  Unless someone
> disagrees, I'm inclined to remove the doc-needed tag here.

That's fine thanks. I've removed it.
Keywords: dev-doc-needed
Any thoughts on removing this material entirely?  What's the situation with ARIA documentation?  Is this stuff all migrated elsewhere, or only specific content?

I don't think it makes sense to keep the obsolete stuff around; I'd like to streamline things and switch to links over to the current material, but don't want to tackle that until I have a clearer notion of what needs to be done.
Comment on attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

a191=beltzner
Attachment #360733 - Flags: approval1.9.1? → approval1.9.1+
Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a043aebfbbcc
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b4
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.