474408 - Remove role="description"

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

This role is unnecessary and has been removed from ARIA. The same information is provided via aria-describedby pointing at an element.

We only need to make sure that we create an accessible object when something is pointed to via describedby. We usually do, because of the code at
http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1258

However, to get this right in all cases we need the inverse relations cache from bug 381599.

In any case, we need to remove it now since it's no longer part of ARIA.

Comment 1

[Aaron Leventhal]

Need to update the testcase page and examples as well.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Aaron, just to be clear this bug can be fixed before bug 381599, correct?

Comment 3

[Aaron Leventhal]

(In reply to comment #2)
> Aaron, just to be clear this bug can be fixed before bug 381599, correct?

Yes, and should.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

OK taking.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: easy fix

All tests pass (I guess we didn't have one for role="description"). I looked through remaining code for other usage but couldn't find any.

Comment 6

[alexander :surkov (:asurkov)]

descripton role is used in mochitest http://mxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/test_nsIAccessNode_utils.html#52 and it is mentioned in http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessibleRole.idl#309

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: changed test case role, tweaked idl comment

Thanks Surkov, it is good to make these changes even if they were harmless. The rest of [grep -Ri "\"description" accessible] looks fine. Note I touched an idl here but didn't change API so no new uuid :)

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

Yep, "note" is the best role in substitution I believe. Thanks!

Comment 9

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/42a0ae473913

Comment 10

[Marco Zehe (:MarcoZ)]

Comment on attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

ARIA 1.0 cleanup, no risk.

Comment 11

[Eric Shepherd [:sheppy]]

It appears that this documentation has been migrated elsewhere.  Unless someone disagrees, I'm inclined to remove the doc-needed tag here.

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #11)
> It appears that this documentation has been migrated elsewhere.  Unless someone
> disagrees, I'm inclined to remove the doc-needed tag here.

That's fine thanks. I've removed it.

Comment 13

[Eric Shepherd [:sheppy]]

Any thoughts on removing this material entirely?  What's the situation with ARIA documentation?  Is this stuff all migrated elsewhere, or only specific content?

I don't think it makes sense to keep the obsolete stuff around; I'd like to streamline things and switch to links over to the current material, but don't want to tackle that until I have a clearer notion of what needs to be done.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 360733 [details] [diff] [review]
changed test case role, tweaked idl comment

a191=beltzner

Comment 15

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a043aebfbbcc

Comment 16

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)