474503 - OS/2 breaks again with enable-test in modules/plugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090120 Minefield/3.2a1pre
Build Identifier: 

After checkin for bug386676 OS/2 fails to build in modules/plugin/test - we are simply not ready for it and should not enter modules/plugin/test at the moment. We just "repaired" our tests to build in modules/plugin/tools/tester in bug471759.
The reason, why we and other platforms not ready to build modules/plugin/test try to build is because this directory is included without a platform test. This was introduced with bug391728. However, we were silently able to build it until major code changes were done in bug386676 and now we fail. I expect other platforms except the tier_1 platforms will fail as well until they introduce some platform specific files in modules/test/testplugin

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
Here is how we error out:
make.exe[5]: Entering directory `E:/mozbuild/modules/plugin/test'
make.exe[6]: Entering directory `E:/mozbuild/modules/plugin/test/testplugin'
nptest.cpp
g++ -o nptest.o -c  -DOSTYPE=\"OS22.45\" -DOSARCH=OS2  -IE:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin -I. -I../../../../dist/include/plugin -I../../../../dist/include   -I../../../../dist/include/nptest -IE:/mozbuild/dist/include/nspr     -IE:/mozbuild/dist/sdk/include       -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic -fno-strict-aliasing -Zomf -pipe  -DNDEBUG -DTRIMMED -O2   -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -Uunix -U__unix -U__unix__ -Wp,-MD,.deps/nptest.pp E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:118: error: parse
   error before `{' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:166: error: parse
   error before `{' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:169: error: ISO
   C++ forbids declaration of `initializeIdentifiers' with no type
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:169: error: new
   declaration `int initializeIdentifiers()'
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:69: error: ambiguates
   old declaration `void initializeIdentifiers()'
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:171: error: ISO
   C++ forbids declaration of `memset' with no type
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:171: error: `
   int memset' redeclared as different kind of symbol
E:/USR/include/string.h:76: error: previous declaration of `void* memset(void*, 
   int, unsigned int)'
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:171: error: initializer
   list being treated as compound expression
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:172: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:173: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:174: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:175: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:176: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:177: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:178: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:179: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:180: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:181: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:182: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:183: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:184: error: syntax
   error before `.' token
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp: In 
   function `NPError NPP_New(char*, NPP_t*, short unsigned int, short int, 
   char**, char**, NPSavedData*)':
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:225: error: `
   memset' cannot be used as a function
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp: In 
   function `NPObject* scriptableAllocate(NPP_t*, NPClass*)':
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:447: error: `
   memset' cannot be used as a function
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp: At top 
   level:
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:169: warning: `
   int initializeIdentifiers()' defined but not used
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:77: warning: `
   void clearIdentifiers()' defined but not used
E:/usr/src/hg/mozilla-central/modules/plugin/test/testplugin/nptest.cpp:141: warning: `
   void fillPluginFunctionTable(NPPluginFuncs*)' defined but not used
make.exe[6]: *** [nptest.o] Error 1

Comment 1

[Walter Meinl]

Attachment: prevent unsupported platforms to build modules/plugin/test

let the test dir only get entered for supported platforms

Comment 2

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/f1214457a197