Closed Bug 474612 Opened 11 years ago Closed 4 years ago

New warnings from NSS_3_12_3_BETA2

Categories

(NSS :: Libraries, defect, P5, trivial)

3.21
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 obsolete file)

Mozilla recently started using NSS_3_12_3_BETA2 (bug 473837). The following new warnings were reported and appear to be valid:

security/nss/lib/freebl/seed.c:613 - unused variable 'num'
security/nss/lib/freebl/seed.c:648 - unused variable 'num'
security/nss/lib/freebl/sha512.c:1110 - unused variable 't1'
security/nss/lib/freebl/sha512.c:814 - unused variable 't1'
security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_x500name.c:74 - 'pkix_pl_X500Name_ToString_Helper' defined but not used
security/nss/lib/pk11wrap/pk11merge.c:684 - unused variable 'needCarry'

For more information about the warning logs, see http://office.smedbergs.us:8080/build?id=855
OS: Linux → All
Priority: -- → P5
Hardware: x86 → All
Version: unspecified → 3.12.3
Severity: normal → trivial
Whiteboard: [build_warning]
The t1 vars seem used by macros, so I've left those alone. But please correct me if I'm wrong!
Attachment #769311 - Flags: review?(wtc)
Review ping?
Comment on attachment 769311 [details] [diff] [review]
Proposed Patch - Remove pkix_pl_X500Name_ToString_Helper v1

Cancelling review - this ended up being done in Bug 1093940.
Attachment #769311 - Attachment is obsolete: true
Attachment #769311 - Flags: review?(wtc)
This will be fixed by Bug 1182667.
Depends on: 1182667
This is fixed. Since this is an NSS big, I'm closing it. It won't hit m-c for about a week though.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Version: 3.12.3 → 3.21
You need to log in before you can comment on or make changes to this bug.