474612 - New warnings from NSS_3_12_3_BETA2

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P5)

Description

[Benjamin Smedberg]

Mozilla recently started using NSS_3_12_3_BETA2 (bug 473837). The following new warnings were reported and appear to be valid:

security/nss/lib/freebl/seed.c:613 - unused variable 'num'
security/nss/lib/freebl/seed.c:648 - unused variable 'num'
security/nss/lib/freebl/sha512.c:1110 - unused variable 't1'
security/nss/lib/freebl/sha512.c:814 - unused variable 't1'
security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_x500name.c:74 - 'pkix_pl_X500Name_ToString_Helper' defined but not used
security/nss/lib/pk11wrap/pk11merge.c:684 - unused variable 'needCarry'

For more information about the warning logs, see http://office.smedbergs.us:8080/build?id=855

Comment 1

[:Cykesiopka]

FWIW,

Bug 453234 fixed:
  security/nss/lib/freebl/seed.c:613 - unused variable 'num'
  security/nss/lib/freebl/seed.c:648 - unused variable 'num'

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/security/nss/lib/freebl&command=DIFF_FRAMESET&file=seed.c&rev1=1.2&rev2=1.3&root=/cvsroot


Bug 515870 fixed:
  security/nss/lib/pk11wrap/pk11merge.c:684 - unused variable 'needCarry'

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/security/nss/lib/pk11wrap&command=DIFF_FRAMESET&file=pk11merge.c&rev1=1.5&rev2=1.6&root=/cvsroot

Comment 2

[:Cykesiopka]

Attachment: Proposed Patch - Remove pkix_pl_X500Name_ToString_Helper v1

The t1 vars seem used by macros, so I've left those alone. But please correct me if I'm wrong!

Comment 3

[:Cykesiopka]

Review ping?

Comment 4

[:Cykesiopka]

Comment on attachment 769311 [details] [diff] [review]
Proposed Patch - Remove pkix_pl_X500Name_ToString_Helper v1

Cancelling review - this ended up being done in Bug 1093940.

Comment 5

[Takanori MATSUURA]

This will be fixed by Bug 1182667.

Comment 6

[Martin Thomson [:mt:]]

This is fixed. Since this is an NSS big, I'm closing it. It won't hit m-c for about a week though.